Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix update vertex validation #1327

Merged
merged 3 commits into from
Nov 2, 2023
Merged

chore: fix update vertex validation #1327

merged 3 commits into from
Nov 2, 2023

Conversation

kohlisid
Copy link
Contributor

@kohlisid kohlisid commented Nov 2, 2023

Fix validation for single vertex update, does not update pipeline when validation requested.
Add mutex to permCount map

@kohlisid kohlisid marked this pull request as ready for review November 2, 2023 19:00
@kohlisid kohlisid requested a review from jy4096 November 2, 2023 19:00
vigith
vigith approved these changes Nov 2, 2023
View reviewed changes
Copy link
Member

@vigith vigith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this dryrun flag is required because we have one end point for validate and update, correct?

@kohlisid
Copy link
Contributor Author

kohlisid commented Nov 2, 2023

@vigith Yes correct!
This check was missing in updateVertex thus we were updating the pipeline even while validating

@kohlisid kohlisid merged commit 4715867 into numaproj:main Nov 2, 2023
17 checks passed
@kohlisid kohlisid deleted the bug-bash branch November 2, 2023 22:41
whynowy pushed a commit that referenced this pull request Nov 3, 2023
@kohlisid @whynowy
chore: fix update vertex validation (#1327)
24a9466 
Signed-off-by: Sidhant Kohli <[email protected]>
(cherry picked from commit 4715867)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jy4096 jy4096 jy4096 approved these changes

@vigith vigith vigith approved these changes

@whynowy whynowy Awaiting requested review from whynowy whynowy is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kohlisid @vigith @jy4096