Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: AuthN/AuthZ for Numaflow UI #1234

Merged
merged 48 commits into from
Oct 26, 2023
Merged

feat: AuthN/AuthZ for Numaflow UI #1234

merged 48 commits into from
Oct 26, 2023

Conversation

vigith
Copy link
Member

@vigith vigith commented Oct 19, 2023 •
edited by KeranYang
Loading

Enables Numaflow UI to do CRUD operations with AuthN/AuthZ.

TODO:

  • TLS
  • Dex reverse proxy (improvement)
  • make Dex configurable
  • "state" use case
  • add root cmd to start the Dex server instead of manually deploy it
  • improvement: revisit set/verify cookie, avoid attack
  • improvement: redirect to the previous page before login (instead of always to the homepage).
  • improvement: refresh token/session, logout
  • Tests
  • Official Github oauth app for default setup
  • logs for all incoming calls (to track who delete/udpate the resources)
  • add -auth flag to enable/disable auth mode
  • complete casbin configuration/full flow

Note: need to add ReadMe

KeranYang and others added 8 commits October 17, 2023 15:24
@KeranYang
chore: add an initial implementation
a68c7cf 
Signed-off-by: Keran Yang <[email protected]>
@bbehnke
feat: login page route (#1222)
c1d5b34 
Signed-off-by: bbehnke <[email protected]>
@darshansimha
Login page skeleton (#1223)
b9d638d 
Signed-off-by: Darshan Simha <[email protected]>
Co-authored-by: Darshan Simha <[email protected]>
@bbehnke
fix: route fix (#1224)
3c2af05 
Signed-off-by: bbehnke <[email protected]>
@bbehnke
feat: user info context and account menu (#1225)
67b0dc2 
Signed-off-by: bbehnke <[email protected]>
@darshansimha
feat: Styling the login page (#1229)
12647f7 
Signed-off-by: Darshan Simha <[email protected]>
Co-authored-by: Darshan Simha <[email protected]>
@jy4096 @dependabot @KeranYang
feat: Dex Initial Intergration (#1228)
5a224a9 
Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: jyu6 <[email protected]>
Signed-off-by: Keran Yang <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: jyu6 <[email protected]>
Co-authored-by: Keran Yang <[email protected]>
@bbehnke
feat: callback handling in login (#1233)
d118208 
Signed-off-by: bbehnke <[email protected]>
@vigith vigith changed the title feat: RBAC feat: AuthN/AuthZ for Numaflow UI Oct 19, 2023
@jy4096
Copy link
Contributor

jy4096 commented Oct 19, 2023

TODO: add --auth flag to enable/disable auth

And then disable auth for api-e2e test.
image

bbehnke and others added 13 commits October 19, 2023 11:23
@bbehnke
fix: clean up and ns installation fixes (#1235)
f6ddd14 
Signed-off-by: bbehnke <[email protected]>
@darshansimha
Div to box update ged (#1237)
57c60ea 
Signed-off-by: Darshan Simha <[email protected]>
Co-authored-by: Darshan Simha <[email protected]>
@bbehnke
fix: login layout tweaks (#1238)
e01ab5a 
Signed-off-by: bbehnke <[email protected]>
@bbehnke
fix: pipeline name click and delete error message (#1240)
374bca8 
Signed-off-by: bbehnke <[email protected]>
@KeranYang
Merge branch 'main' into ged-rbac
b230307
@KeranYang
chore: clean up unused code snippets (#1242)
2ebbbef 
Signed-off-by: Keran Yang <[email protected]>
@kohlisid @bbehnke @KeranYang
feat: add authorization layer (#1239)
03ef205 
Signed-off-by: Sidhant Kohli <[email protected]>
Co-authored-by: Bradley Behnke <[email protected]>
Co-authored-by: Keran Yang <[email protected]>
@whynowy
args for disableAuth, dexServerAddr, etc (#1245)
ffd6fe0 
Signed-off-by: Derek Wang <[email protected]>
@whynowy
manifests and config (#1249)
0316406
@whynowy
Merge branch 'main' into ged-rbac
76b0eb6
@whynowy
remove ingress file
e6601fe 
Signed-off-by: Derek Wang <[email protected]>
@whynowy
remove pk and certs
94aa2da 
Signed-off-by: Derek Wang <[email protected]>
@darshansimha
fix: fixed the background height to suit smaller screens (#1248)
4c4730a 
Co-authored-by: Darshan Simha <[email protected]>
@KeranYang KeranYang mentioned this pull request Oct 23, 2023
Merged
vigith and others added 22 commits October 24, 2023 19:50
@vigith
Merge branch 'main' into ged-rbac
4c87581
@bbehnke
Merge branch 'main' into ged-rbac
58e0f13
@bbehnke
fix: login input styling, px to rem updates and create w/o mutate (#1254
3b3bd38 
)

Signed-off-by: bbehnke <[email protected]>
@bbehnke
fix: try again for delete and updated 403 messages (#1265)
8b6bfde 
Signed-off-by: bbehnke <[email protected]>
@bbehnke
Merge branch 'main' into ged-rbac
dc953ad
@KeranYang
chore: authenticate user before each api call (#1259)
e25571d 
Signed-off-by: Keran Yang <[email protected]>
@vigith
chore: add header (#1267)
670fc92 
Signed-off-by: Vigith Maurice <[email protected]>
@bbehnke
Merge branch 'main' into ged-rbac
e404f85
@KeranYang
chore: add header (#1270)
b1c893c 
Signed-off-by: Keran Yang <[email protected]>
@bbehnke
fix: disabled existing ood tests and added slidingsidebar test (#1269)
8a1a88f
@jy4096
chore: cleanup and test fix (#1261)
7333d5d 
Signed-off-by: jyu6 <[email protected]>
@bbehnke
fix: more sidebar tests (#1273)
0e69102 
Signed-off-by: bbehnke <[email protected]>
@mshakira @bbehnke
fix(SERVER): update gradient test (#1271)
0ed39a8 
Signed-off-by: Shakira M <[email protected]>
Co-authored-by: Shakira M <[email protected]>
Co-authored-by: Bradley Behnke <[email protected]>
@KeranYang
chore: only instantiate dex object once (#1272)
42da79a 
Signed-off-by: Keran Yang <[email protected]>
@whynowy
Merge branch 'main' into ged-rbac
5302ef3
@whynowy
Merge branch 'main' into ged-rbac
8244b1a
@whynowy
spec update
0ac3c30 
Signed-off-by: Derek Wang <[email protected]>
@whynowy
manifests
4056616 
Signed-off-by: Derek Wang <[email protected]>
@whynowy
minor
a7145c0 
Signed-off-by: Derek Wang <[email protected]>
@whynowy
Merge branch 'main' into ged-rbac
c210ce1
@whynowy
rename
5019634 
Signed-off-by: Derek Wang <[email protected]>
@bbehnke
fix: generatorupdate unit test (#1277)
9dd535c 
Signed-off-by: bbehnke <[email protected]>
@whynowy whynowy marked this pull request as ready for review October 26, 2023 17:36
@whynowy whynowy self-requested a review as a code owner October 26, 2023 17:36
@vigith vigith merged commit 36610a5 into main Oct 26, 2023
17 checks passed
@vigith vigith deleted the ged-rbac branch October 26, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whynowy whynowy whynowy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@vigith @jy4096 @whynowy @KeranYang @bbehnke @darshansimha @kohlisid @mshakira