Merge branch 'main' into bidi-source

docs/user-guide/reference/configuration/volumes.md

@@ -47,3 +47,28 @@ spec:
               - mountPath: /path/to/my-sink-config
                 name: my-udsink-config
 ```
+
+## PVC Example
+
+Example to show how to attach a Persistent Volume Claim (PVC) to a container.
+
+```yaml
+apiVersion: numaflow.numaproj.io/v1alpha1
+kind: Pipeline
+metadata:
+  name: my-pipeline
+spec:
+  vertices:
+    - name: my-source
+      volumes:
+        - name: mypd
+          persistentVolumeClaim:
+            claimName: myclaim
+      source:
+        udsource:
+          container:
+            image: my-source:latest
+            volumeMounts:
+              - mountPath: /path/to/my-source-config
+                name: mypd
+```

pkg/reconciler/pipeline/controller.go

@@ -610,7 +610,7 @@ func buildVertices(pl *dfv1.Pipeline) map[string]dfv1.Vertex {
 		copyVertexTemplate(pl, vCopy)
 		copyVertexLimits(pl, vCopy)
 		replicas := int32(1)
-		// If the desired phase is pause or we are in the middle of pausing we should not start any vertex replicas
+		// If the desired phase is paused or we are in the middle of pausing we should not start any vertex replicas
 		if isLifecycleChange(pl) {
 			replicas = int32(0)
 		} else if v.IsReduceUDF() {
@@ -952,7 +952,7 @@ func (r *pipelineReconciler) checkChildrenResourceStatus(ctx context.Context, pi
 	defer func() {
 		for _, c := range pipeline.Status.Conditions {
 			if c.Status != metav1.ConditionTrue {
-				pipeline.Status.SetPhase(pipeline.Spec.Lifecycle.GetDesiredPhase(), "Degraded: "+c.Message)
+				pipeline.Status.Message = "Degraded: " + c.Message
 				return
 			}
 		}