Skip to content

Commit

Permalink
chore: mark kafka include-headers as experimental (#1570)
Browse files Browse the repository at this point in the history
Signed-off-by: Vigith Maurice <[email protected]>
  • Loading branch information
vigith authored Mar 15, 2024
1 parent 4457ac8 commit 9fa339e
Show file tree
Hide file tree
Showing 6 changed files with 8 additions and 4 deletions.
2 changes: 1 addition & 1 deletion api/json-schema/schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -18850,7 +18850,7 @@
"type": "string"
},
"includeHeaders": {
"description": "include Kafka headers (this will change the payload struct into a JSON format with _body and _headers)",
"description": "include Kafka headers (this will change the payload struct into a JSON format with _body and _headers) EXPERIMENTAL: We might remove this option later on (https://github.com/numaproj/numaflow/issues/1568)",
"type": "boolean"
},
"sasl": {
Expand Down
2 changes: 1 addition & 1 deletion api/openapi-spec/swagger.json
Original file line number Diff line number Diff line change
Expand Up @@ -18849,7 +18849,7 @@
"type": "string"
},
"includeHeaders": {
"description": "include Kafka headers (this will change the payload struct into a JSON format with _body and _headers)",
"description": "include Kafka headers (this will change the payload struct into a JSON format with _body and _headers) EXPERIMENTAL: We might remove this option later on (https://github.com/numaproj/numaflow/issues/1568)",
"type": "boolean"
},
"sasl": {
Expand Down
4 changes: 3 additions & 1 deletion docs/APIs.md
Original file line number Diff line number Diff line change
Expand Up @@ -2792,7 +2792,9 @@ default for SASL.
<em>(Optional)</em>
<p>
include Kafka headers (this will change the payload struct into a JSON
format with \_body and \_headers)
format with \_body and \_headers) EXPERIMENTAL: We might remove this
option later on
(<a href="https://github.com/numaproj/numaflow/issues/1568">https://github.com/numaproj/numaflow/issues/1568</a>)
</p>
</td>
</tr>
Expand Down
1 change: 1 addition & 0 deletions pkg/apis/numaflow/v1alpha1/generated.proto

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions pkg/apis/numaflow/v1alpha1/kafka_source.go
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ type KafkaSource struct {
// +optional
SASL *SASL `json:"sasl" protobuf:"bytes,6,opt,name=sasl"`
// include Kafka headers (this will change the payload struct into a JSON format with _body and _headers)
// EXPERIMENTAL: We might remove this option later on (https://github.com/numaproj/numaflow/issues/1568)
// +optional
IncludeHeaders bool `json:"includeHeaders" protobuf:"bytes,7,opt,name=includeHeaders"`
}
2 changes: 1 addition & 1 deletion pkg/apis/numaflow/v1alpha1/openapi_generated.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 9fa339e

Please sign in to comment.