Skip to content

Commit

Permalink
chore: Migrate from upload/download artifacts action v3 to v4 (#2314)
Browse files Browse the repository at this point in the history
  • Loading branch information
BulkBeing authored Jan 8, 2025
1 parent b6c4de1 commit 97b84cf
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 15 deletions.
12 changes: 6 additions & 6 deletions .github/workflows/nightly-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:
- name: Make checksums
run: make checksums
- name: store artifacts
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: binaries
path: dist
Expand Down Expand Up @@ -65,7 +65,7 @@ jobs:
- name: Rename binary
run: cp -pv target/x86_64-unknown-linux-gnu/release/numaflow numaflow-rs-linux-amd64
- name: Upload numaflow binary
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: numaflow-rs-linux-amd64
path: rust/numaflow-rs-linux-amd64
Expand Down Expand Up @@ -98,7 +98,7 @@ jobs:
- name: Rename binary
run: cp -pv target/aarch64-unknown-linux-gnu/release/numaflow numaflow-rs-linux-arm64
- name: Upload numaflow binary
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: numaflow-rs-linux-arm64
path: rust/numaflow-rs-linux-arm64
Expand Down Expand Up @@ -127,19 +127,19 @@ jobs:
uses: docker/setup-buildx-action@v2

- name: Download Go binaries
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: binaries
path: dist/

- name: Download Rust amd64 binaries
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: numaflow-rs-linux-amd64
path: dist/

- name: Download Rust arm64 binaries
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: numaflow-rs-linux-arm64
path: dist/
Expand Down
18 changes: 9 additions & 9 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
- name: Make checksums
run: make checksums
- name: store artifacts
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: binaries
path: dist
Expand All @@ -56,7 +56,7 @@ jobs:
- name: Rename binary
run: cp -pv target/x86_64-unknown-linux-gnu/release/numaflow numaflow-rs-linux-amd64
- name: Upload numaflow binary
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: numaflow-rs-linux-amd64
path: rust/numaflow-rs-linux-amd64
Expand All @@ -82,7 +82,7 @@ jobs:
- name: Rename binary
run: cp -pv target/aarch64-unknown-linux-gnu/release/numaflow numaflow-rs-linux-arm64
- name: Upload numaflow binary
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: numaflow-rs-linux-arm64
path: rust/numaflow-rs-linux-arm64
Expand Down Expand Up @@ -111,19 +111,19 @@ jobs:
uses: docker/setup-buildx-action@v2

- name: Download Go binaries
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: binaries
path: dist/

- name: Download Rust amd64 binaries
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: numaflow-rs-linux-amd64
path: dist/

- name: Download Rust arm64 binaries
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: numaflow-rs-linux-arm64
path: dist/
Expand Down Expand Up @@ -171,7 +171,7 @@ jobs:
- run: bom generate --image quay.io/numaproj/numaflow:$VERSION -o /tmp/numaflow.spdx
# pack the boms into one file to make it easy to download
- run: cd /tmp && tar -zcf sbom.tar.gz *.spdx
- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
with:
name: sbom.tar.gz
path: /tmp/sbom.tar.gz
Expand All @@ -191,11 +191,11 @@ jobs:
echo "VERSION=${GITHUB_REF##*/}" >> $GITHUB_ENV
fi
- name: Download binaries
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: binaries
path: dist/
- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: sbom.tar.gz
path: /tmp
Expand Down

0 comments on commit 97b84cf

Please sign in to comment.