fix: memory leak inside session windower (#1445)

Signed-off-by: Yashash H L <[email protected]>
numaproj · Jan 11, 2024 · 85e76c7 · 85e76c7
1 parent 4306357
commit 85e76c7
Show file tree

Hide file tree

Showing 30 changed files with 785 additions and 493 deletions.
diff --git a/api/json-schema/schema.json b/api/json-schema/schema.json
@@ -17819,6 +17819,10 @@
         "duration": {
           "$ref": "#/definitions/io.k8s.apimachinery.pkg.apis.meta.v1.Duration"
         },
+        "jitter": {
+          "$ref": "#/definitions/io.k8s.apimachinery.pkg.apis.meta.v1.Duration",
+          "description": "Jitter is the jitter for the message generation, used to simulate out of order messages for example if the jitter is 10s, then the message's event time will be delayed by a random time between 0 and 10s which will result in the message being out of order by 0 to 10s"
+        },
         "keyCount": {
           "description": "KeyCount is the number of unique keys in the payload",
           "format": "int32",

diff --git a/api/openapi-spec/swagger.json b/api/openapi-spec/swagger.json
@@ -17824,6 +17824,10 @@
         "duration": {
           "$ref": "#/definitions/io.k8s.apimachinery.pkg.apis.meta.v1.Duration"
         },
+        "jitter": {
+          "description": "Jitter is the jitter for the message generation, used to simulate out of order messages for example if the jitter is 10s, then the message's event time will be delayed by a random time between 0 and 10s which will result in the message being out of order by 0 to 10s",
+          "$ref": "#/definitions/io.k8s.apimachinery.pkg.apis.meta.v1.Duration"
+        },
         "keyCount": {
           "description": "KeyCount is the number of unique keys in the payload",
           "type": "integer",

diff --git a/config/base/crds/full/numaflow.numaproj.io_pipelines.yaml b/config/base/crds/full/numaflow.numaproj.io_pipelines.yaml
@@ -6928,6 +6928,9 @@ spec:
                             duration:
                               default: 1s
                               type: string
+                            jitter:
+                              default: 0s
+                              type: string
                             keyCount:
                               format: int32
                               type: integer

diff --git a/config/base/crds/full/numaflow.numaproj.io_vertices.yaml b/config/base/crds/full/numaflow.numaproj.io_vertices.yaml
@@ -2766,6 +2766,9 @@ spec:
                       duration:
                         default: 1s
                         type: string
+                      jitter:
+                        default: 0s
+                        type: string
                       keyCount:
                         format: int32
                         type: integer

diff --git a/config/install.yaml b/config/install.yaml
@@ -9457,6 +9457,9 @@ spec:
                             duration:
                               default: 1s
                               type: string
+                            jitter:
+                              default: 0s
+                              type: string
                             keyCount:
                               format: int32
                               type: integer
@@ -14056,6 +14059,9 @@ spec:
                       duration:
                         default: 1s
                         type: string
+                      jitter:
+                        default: 0s
+                        type: string
                       keyCount:
                         format: int32
                         type: integer

diff --git a/config/namespace-install.yaml b/config/namespace-install.yaml
@@ -9457,6 +9457,9 @@ spec:
                             duration:
                               default: 1s
                               type: string
+                            jitter:
+                              default: 0s
+                              type: string
                             keyCount:
                               format: int32
                               type: integer
@@ -14056,6 +14059,9 @@ spec:
                       duration:
                         default: 1s
                         type: string
+                      jitter:
+                        default: 0s
+                        type: string
                       keyCount:
                         format: int32
                         type: integer

diff --git a/docs/APIs.md b/docs/APIs.md
@@ -1330,6 +1330,7 @@ Size of each generated message
 <code>keyCount</code></br> <em> int32 </em>
 </td>
 <td>
+<em>(Optional)</em>
 <p>
 KeyCount is the number of unique keys in the payload
 </p>
@@ -1340,11 +1341,28 @@ KeyCount is the number of unique keys in the payload
 <code>value</code></br> <em> uint64 </em>
 </td>
 <td>
+<em>(Optional)</em>
 <p>
 Value is an optional uint64 value to be written in to the payload
 </p>
 </td>
 </tr>
+<tr>
+<td>
+<code>jitter</code></br> <em>
+<a href="https://pkg.go.dev/k8s.io/apimachinery/pkg/apis/meta/v1#Duration">
+Kubernetes meta/v1.Duration </a> </em>
+</td>
+<td>
+<em>(Optional)</em>
+<p>
+Jitter is the jitter for the message generation, used to simulate out of
+order messages for example if the jitter is 10s, then the message’s
+event time will be delayed by a random time between 0 and 10s which will
+result in the message being out of order by 0 to 10s
+</p>
+</td>
+</tr>
 </tbody>
 </table>
 <h3 id="numaflow.numaproj.io/v1alpha1.GetDaemonDeploymentReq">