Skip to content

Commit

Permalink
fix: skip updating phase for resource check (#2065)
Browse files Browse the repository at this point in the history
Signed-off-by: Sidhant Kohli <[email protected]>
  • Loading branch information
kohlisid authored Sep 17, 2024
1 parent 910ff9b commit 692fbee
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions pkg/reconciler/pipeline/controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -610,7 +610,7 @@ func buildVertices(pl *dfv1.Pipeline) map[string]dfv1.Vertex {
copyVertexTemplate(pl, vCopy)
copyVertexLimits(pl, vCopy)
replicas := int32(1)
// If the desired phase is pause or we are in the middle of pausing we should not start any vertex replicas
// If the desired phase is paused or we are in the middle of pausing we should not start any vertex replicas
if isLifecycleChange(pl) {
replicas = int32(0)
} else if v.IsReduceUDF() {
Expand Down Expand Up @@ -952,7 +952,7 @@ func (r *pipelineReconciler) checkChildrenResourceStatus(ctx context.Context, pi
defer func() {
for _, c := range pipeline.Status.Conditions {
if c.Status != metav1.ConditionTrue {
pipeline.Status.SetPhase(pipeline.Spec.Lifecycle.GetDesiredPhase(), "Degraded: "+c.Message)
pipeline.Status.Message = "Degraded: " + c.Message
return
}
}
Expand Down

0 comments on commit 692fbee

Please sign in to comment.