tooltip content formatting - two decimal precision & unit

Signed-off-by: adarsh0728 <[email protected]>
numaproj · Jan 17, 2025 · 5930e70 · 5930e70
1 parent 33b992b
commit 5930e70
Show file tree

Hide file tree

Showing 4 changed files with 38 additions and 32 deletions.
diff --git a/server/apis/v1/handler.go b/server/apis/v1/handler.go
@@ -1340,7 +1340,7 @@ func (h *handler) DiscoverMetrics(c *gin.Context) {
 					})
 				}
 
-				discoveredMetrics = append(discoveredMetrics, NewDiscoveryResponse(metric.Name, metric.DisplayName, metric.Unit, dimensionData))
+				discoveredMetrics = append(discoveredMetrics, NewDiscoveryResponse(pattern.Name, metric.Name, metric.DisplayName, metric.Unit, dimensionData))
 			}
 		}
 	}

diff --git a/server/apis/v1/response_metrics.go b/server/apis/v1/response_metrics.go
@@ -11,13 +11,14 @@ const (
 )
 
 type MetricsRequestBody struct {
-	MetricName string            `json:"metric_name"`
-	Dimension  string            `json:"dimension"`
-	Filters    map[string]string `json:"filters"`
-	Duration   string            `json:"duration"`
-	Quantile   string            `json:"quantile"`
-	StartTime  string            `json:"start_time"`
-	EndTime    string            `json:"end_time"`
+	PatternName string            `json:"name"`
+	MetricName  string            `json:"metric_name"`
+	Dimension   string            `json:"dimension"`
+	Filters     map[string]string `json:"filters"`
+	Duration    string            `json:"duration"`
+	Quantile    string            `json:"quantile"`
+	StartTime   string            `json:"start_time"`
+	EndTime     string            `json:"end_time"`
 }
 
 type Filter struct {

diff --git a/server/apis/v1/response_metrics_discovery.go b/server/apis/v1/response_metrics_discovery.go
@@ -7,6 +7,7 @@ type Dimensions struct {
 }
 
 type DiscoveryResponse struct {
+	PatternName string       `json:"name"`
 	MetricName  string       `json:"metric_name"`
 	DisplayName string       `json:"display_name"`
 	Unit        string       `json:"unit"`
@@ -17,8 +18,9 @@ type DiscoveryResponse struct {
 type MetricsDiscoveryResponse []DiscoveryResponse
 
 // NewDiscoveryResponse creates a new DiscoveryResponse object for each metric.
-func NewDiscoveryResponse(metricName, displayName, unitName string, dimensions []Dimensions) DiscoveryResponse {
+func NewDiscoveryResponse(patternName, metricName, displayName, unitName string, dimensions []Dimensions) DiscoveryResponse {
 	return DiscoveryResponse{
+		PatternName: patternName,
 		MetricName:  metricName,
 		DisplayName: displayName,
 		Unit:        unitName,

diff --git a/.../NodeInfo/partials/Pods/partials/PodDetails/partials/Metrics/partials/LineChart/index.tsx b/.../NodeInfo/partials/Pods/partials/PodDetails/partials/Metrics/partials/LineChart/index.tsx
-Original file line number
+Diff line change
@@ Expand Up / @@ -1340,7 +1340,7 @@ func (h *handler) DiscoverMetrics(c *gin.Context) { @@
     					})
     				}
-    				discoveredMetrics = append(discoveredMetrics, NewDiscoveryResponse(metric.Name, metric.DisplayName, metric.Unit, dimensionData))
+    				discoveredMetrics = append(discoveredMetrics, NewDiscoveryResponse(pattern.Name, metric.Name, metric.DisplayName, metric.Unit, dimensionData))
     			}
     		}
     	}
@@ Expand Down @@