Skip to content

Commit

Permalink
Fix golangci-lint errors
Browse files Browse the repository at this point in the history
Signed-off-by: Sreekanth <[email protected]>
  • Loading branch information
BulkBeing committed Sep 23, 2024
1 parent 6a6a289 commit 14929ea
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
2 changes: 1 addition & 1 deletion pkg/udf/forward/forward.go
Original file line number Diff line number Diff line change
Expand Up @@ -481,7 +481,7 @@ func (isdf *InterStepDataForward) streamMessage(ctx context.Context, dataMessage
if len(dataMessages) > 1 {
errMsg := "data message size is not 1 with map UDF streaming"
isdf.opts.logger.Errorw(errMsg)
return nil, fmt.Errorf(errMsg)
return nil, errors.New(errMsg)
} else if len(dataMessages) == 1 {
// send to map UDF only the data messages

Expand Down
5 changes: 4 additions & 1 deletion pkg/webhook/validator/validator.go
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,10 @@ func GetValidator(ctx context.Context, NumaClient v1alpha1.NumaflowV1alpha1Inter

// DeniedResponse constructs a denied AdmissionResponse
func DeniedResponse(reason string, args ...interface{}) *admissionv1.AdmissionResponse {
result := apierrors.NewBadRequest(fmt.Sprintf(reason, args...)).Status()
if len(args) > 0 {
reason = fmt.Sprintf(reason, args)
}
result := apierrors.NewBadRequest(reason).Status()
return &admissionv1.AdmissionResponse{
Result: &result,
Allowed: false,
Expand Down
2 changes: 1 addition & 1 deletion test/transformer-e2e/transformer_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ func (s *TransformerSuite) TestSourceTransformer() {
}

var wg sync.WaitGroup
wg.Add(4)
wg.Add(1)
// FIXME: Enable these tests after corresponding SDKs are changed to support bidirectional streaming
//go func() {
// defer wg.Done()
Expand Down

0 comments on commit 14929ea

Please sign in to comment.