Skip to content

Commit

Permalink
feat: counter metrics visualizer for mono-vertex (#2256)
Browse files Browse the repository at this point in the history 
Signed-off-by: adarsh0728 <[email protected]>
  • Loading branch information
@adarsh0728
adarsh0728 authored Dec 10, 2024
1 parent 8bed236 commit 059a585
Show file tree
Hide file tree
Showing 7 changed files with 214 additions and 66 deletions.
55 changes: 42 additions & 13 deletions config/advanced-install/namespaced-numaflow-server.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ metadata:
---
apiVersion: v1
data:
config.yaml: |
config.yaml: |-
# url is a required field, it should be the url of the service to which the metrics proxy will connect
# url: service_name + "." + service_namespace + ".svc.cluster.local" + ":" + port
# example for local prometheus service
Expand Down Expand Up @@ -191,28 +191,30 @@ data:
- namespace
- mvtx_name
dimensions:
- name: mono-vertex
# expr: optional expression for prometheus query
# overrides the default expression
- name: pod
# expr: optional expression for prometheus query
# overrides the default expression
filters:
- name: pod
required: false
- metric_name: monovtx_sink_time_bucket
required_filters:
- namespace
- mvtx_name
dimensions:
- name: mono-vertex
# expr: optional expression for prometheus query
# overrides the default expression
- name: pod
# expr: optional expression for prometheus query
# overrides the default expression
filters:
- name: pod
required: false
# Add histogram metrics similar to the pattern above
#- metric_name: monovtx_sink_time_bucket
# required_filters:
# - namespace
# - mvtx_name
# dimensions:
# - name: pod
# #expr: optional
# filters:
# - name: pod
# required: false
# - name: mono-vertex
# #expr: optional
- name: vertex_throughput
object: vertex
title: Vertex Throughput and Message Rates
Expand All @@ -239,6 +241,33 @@ data:
filters:
- name: pod
required: false
- name: mono_vertex_throughput
object: mono-vertex
title: Mono-Vertex Throughput and Message Rates
description: This pattern measures the throughput of a mono-vertex in messages per second across different dimensions
expr: sum(rate($metric_name{$filters}[$duration])) by ($dimension)
params:
- name: duration
required: true
- name: start_time
required: false
- name: end_time
required: false
metrics:
- metric_name: monovtx_read_total
required_filters:
- namespace
- mvtx_name
dimensions:
- name: mono-vertex
# expr: optional expression for prometheus query
# overrides the default expression
- name: pod
# expr: optional expression for prometheus query
# overrides the default expression
filters:
- name: pod
required: false
kind: ConfigMap
metadata:
name: numaflow-server-metrics-proxy-config
Expand Down
55 changes: 42 additions & 13 deletions config/advanced-install/numaflow-server.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ metadata:
---
apiVersion: v1
data:
config.yaml: |
config.yaml: |-
# url is a required field, it should be the url of the service to which the metrics proxy will connect
# url: service_name + "." + service_namespace + ".svc.cluster.local" + ":" + port
# example for local prometheus service
Expand Down Expand Up @@ -198,28 +198,30 @@ data:
- namespace
- mvtx_name
dimensions:
- name: mono-vertex
# expr: optional expression for prometheus query
# overrides the default expression
- name: pod
# expr: optional expression for prometheus query
# overrides the default expression
filters:
- name: pod
required: false
- metric_name: monovtx_sink_time_bucket
required_filters:
- namespace
- mvtx_name
dimensions:
- name: mono-vertex
# expr: optional expression for prometheus query
# overrides the default expression
- name: pod
# expr: optional expression for prometheus query
# overrides the default expression
filters:
- name: pod
required: false
# Add histogram metrics similar to the pattern above
#- metric_name: monovtx_sink_time_bucket
# required_filters:
# - namespace
# - mvtx_name
# dimensions:
# - name: pod
# #expr: optional
# filters:
# - name: pod
# required: false
# - name: mono-vertex
# #expr: optional
- name: vertex_throughput
object: vertex
title: Vertex Throughput and Message Rates
Expand All @@ -246,6 +248,33 @@ data:
filters:
- name: pod
required: false
- name: mono_vertex_throughput
object: mono-vertex
title: Mono-Vertex Throughput and Message Rates
description: This pattern measures the throughput of a mono-vertex in messages per second across different dimensions
expr: sum(rate($metric_name{$filters}[$duration])) by ($dimension)
params:
- name: duration
required: true
- name: start_time
required: false
- name: end_time
required: false
metrics:
- metric_name: monovtx_read_total
required_filters:
- namespace
- mvtx_name
dimensions:
- name: mono-vertex
# expr: optional expression for prometheus query
# overrides the default expression
- name: pod
# expr: optional expression for prometheus query
# overrides the default expression
filters:
- name: pod
required: false
kind: ConfigMap
metadata:
name: numaflow-server-metrics-proxy-config
Expand Down
53 changes: 41 additions & 12 deletions config/base/numaflow-server/numaflow-server-metrics-proxy-config.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -57,28 +57,30 @@ data:
- namespace
- mvtx_name
dimensions:
- name: mono-vertex
# expr: optional expression for prometheus query
# overrides the default expression
- name: pod
# expr: optional expression for prometheus query
# overrides the default expression
filters:
- name: pod
required: false
- metric_name: monovtx_sink_time_bucket
required_filters:
- namespace
- mvtx_name
dimensions:
- name: mono-vertex
# expr: optional expression for prometheus query
# overrides the default expression
- name: pod
# expr: optional expression for prometheus query
# overrides the default expression
filters:
- name: pod
required: false
# Add histogram metrics similar to the pattern above
#- metric_name: monovtx_sink_time_bucket
# required_filters:
# - namespace
# - mvtx_name
# dimensions:
# - name: pod
# #expr: optional
# filters:
# - name: pod
# required: false
# - name: mono-vertex
# #expr: optional
- name: vertex_throughput
object: vertex
title: Vertex Throughput and Message Rates
Expand All @@ -105,3 +107,30 @@ data:
filters:
- name: pod
required: false
- name: mono_vertex_throughput
object: mono-vertex
title: Mono-Vertex Throughput and Message Rates
description: This pattern measures the throughput of a mono-vertex in messages per second across different dimensions
expr: sum(rate($metric_name{$filters}[$duration])) by ($dimension)
params:
- name: duration
required: true
- name: start_time
required: false
- name: end_time
required: false
metrics:
- metric_name: monovtx_read_total
required_filters:
- namespace
- mvtx_name
dimensions:
- name: mono-vertex
# expr: optional expression for prometheus query
# overrides the default expression
- name: pod
# expr: optional expression for prometheus query
# overrides the default expression
filters:
- name: pod
required: false
55 changes: 42 additions & 13 deletions config/install.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -28557,7 +28557,7 @@ metadata:
---
apiVersion: v1
data:
config.yaml: |
config.yaml: |-
# url is a required field, it should be the url of the service to which the metrics proxy will connect
# url: service_name + "." + service_namespace + ".svc.cluster.local" + ":" + port
# example for local prometheus service
Expand Down Expand Up @@ -28611,28 +28611,30 @@ data:
- namespace
- mvtx_name
dimensions:
- name: mono-vertex
# expr: optional expression for prometheus query
# overrides the default expression
- name: pod
# expr: optional expression for prometheus query
# overrides the default expression
filters:
- name: pod
required: false
- metric_name: monovtx_sink_time_bucket
required_filters:
- namespace
- mvtx_name
dimensions:
- name: mono-vertex
# expr: optional expression for prometheus query
# overrides the default expression
- name: pod
# expr: optional expression for prometheus query
# overrides the default expression
filters:
- name: pod
required: false
# Add histogram metrics similar to the pattern above
#- metric_name: monovtx_sink_time_bucket
# required_filters:
# - namespace
# - mvtx_name
# dimensions:
# - name: pod
# #expr: optional
# filters:
# - name: pod
# required: false
# - name: mono-vertex
# #expr: optional
- name: vertex_throughput
object: vertex
title: Vertex Throughput and Message Rates
Expand All @@ -28659,6 +28661,33 @@ data:
filters:
- name: pod
required: false
- name: mono_vertex_throughput
object: mono-vertex
title: Mono-Vertex Throughput and Message Rates
description: This pattern measures the throughput of a mono-vertex in messages per second across different dimensions
expr: sum(rate($metric_name{$filters}[$duration])) by ($dimension)
params:
- name: duration
required: true
- name: start_time
required: false
- name: end_time
required: false
metrics:
- metric_name: monovtx_read_total
required_filters:
- namespace
- mvtx_name
dimensions:
- name: mono-vertex
# expr: optional expression for prometheus query
# overrides the default expression
- name: pod
# expr: optional expression for prometheus query
# overrides the default expression
filters:
- name: pod
required: false
kind: ConfigMap
metadata:
name: numaflow-server-metrics-proxy-config
Expand Down
Loading

0 comments on commit 059a585

Please sign in to comment.