use ubuntu latest

Signed-off-by: Yashash H L <[email protected]>
numaproj · Sep 13, 2024 · 02fca5d · 02fca5d
1 parent 2fb827f
commit 02fca5d
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 39 deletions.
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -9,7 +9,7 @@ on:
 jobs:
   ui:
     name: UI
-    runs-on: ubuntu-24.04
+    runs-on: ubuntu-latest
     timeout-minutes: 6
     steps:
       - name: Checkout code
@@ -131,7 +131,7 @@ jobs:
 
   lint:
     name: Lint
-    runs-on: ubuntu-24.04
+    runs-on: ubuntu-latest
     timeout-minutes: 10
     env:
       GOPATH: /home/runner/go
@@ -184,7 +184,7 @@ jobs:
 
   e2e-tests:
     name: E2E Tests
-    runs-on: ubuntu-24.04
+    runs-on: ubuntu-latest
     needs: [ build-rust-amd64 ]
     timeout-minutes: 20
     strategy:

diff --git a/pkg/sdkclient/options.go b/pkg/sdkclient/options.go
@@ -16,17 +16,9 @@ limitations under the License.
 
 package sdkclient
 
-import (
-	"time"
-
-	"github.com/numaproj/numaflow/pkg/apis/numaflow/v1alpha1"
-)
-
 type Options struct {
 	udsSockAddr    string
 	maxMessageSize int
-	readBatchSize  int
-	readTimeout    time.Duration
 }
 
 // UdsSockAddr returns the UDS sock addr.
@@ -39,23 +31,11 @@ func (o *Options) MaxMessageSize() int {
 	return o.maxMessageSize
 }
 
-// ReadBatchSize returns the read batch size.
-func (o *Options) ReadBatchSize() int {
-	return o.readBatchSize
-}
-
-// ReadTimeout returns the read timeout.
-func (o *Options) ReadTimeout() time.Duration {
-	return o.readTimeout
-}
-
 // DefaultOptions returns the default options.
 func DefaultOptions(address string) *Options {
 	return &Options{
 		maxMessageSize: DefaultGRPCMaxMessageSize,
 		udsSockAddr:    address,
-		readBatchSize:  v1alpha1.DefaultReadBatchSize,
-		readTimeout:    v1alpha1.DefaultReadTimeout,
 	}
 }
 
@@ -75,17 +55,3 @@ func WithMaxMessageSize(size int) Option {
 		opts.maxMessageSize = size
 	}
 }
-
-// WithReadBatchSize sets the read batch size.
-func WithReadBatchSize(size int) Option {
-	return func(opts *Options) {
-		opts.readBatchSize = size
-	}
-}
-
-// WithReadTimeout sets the read timeout.
-func WithReadTimeout(timeout time.Duration) Option {
-	return func(opts *Options) {
-		opts.readTimeout = timeout
-	}
-}
diff --git a/rust/monovertex/build.rs b/rust/monovertex/build.rs
@@ -1,7 +1,6 @@
 fn main() {
     tonic_build::configure()
         .build_server(true)
-        .protoc_arg("--experimental_allow_proto3_optional")
         .compile(
             &[
                 "proto/source.proto",

diff --git a/test/e2e/functional_test.go b/test/e2e/functional_test.go
@@ -41,7 +41,7 @@ func (s *FunctionalSuite) TestCreateSimplePipeline() {
 	w := s.Given().Pipeline("@testdata/simple-pipeline.yaml").
 		When().
 		CreatePipelineAndWait()
-	defer w.DeletePipelineAndWait()
+	//defer w.DeletePipelineAndWait()
 	pipelineName := "simple-pipeline"
 
 	w.Expect().
@@ -146,6 +146,7 @@ func (s *FunctionalSuite) TestCreateSimplePipeline() {
 		assert.Fail(s.T(), "timed out waiting for rate to be calculated")
 	}
 	timer.Stop()
+	time.Sleep(300 * time.Second)
 }
 
 func (s *FunctionalSuite) TestUDFFiltering() {