Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: bidirectional streaming for udsink #90

Merged
merged 9 commits into from
Sep 26, 2024
Merged

feat: bidirectional streaming for udsink #90

merged 9 commits into from
Sep 26, 2024

Conversation

yhl25
Copy link
Contributor

@yhl25 yhl25 commented Sep 25, 2024

No description provided.

@yhl25
feat: bidirectional streaming for udsink
a299a51 
Signed-off-by: Yashash H L <[email protected]>
@yhl25
handshake
6f67004 
Signed-off-by: Yashash H L <[email protected]>
@yhl25
don't return early
8724e43 
Signed-off-by: Yashash H L <[email protected]>
@yhl25
consider eot
0c16828 
Signed-off-by: Yashash H L <[email protected]>
@yhl25
comments
026322e 
Signed-off-by: Yashash H L <[email protected]>
vigith
vigith reviewed Sep 25, 2024
View reviewed changes
Copy link
Member

@vigith vigith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weren't you following _pb for proto modules?

yhl25 and others added 4 commits September 26, 2024 13:21
@yhl25
update example
a1c3dc1 
Signed-off-by: Yashash H L <[email protected]>
@vigith
feat: suffix proto mod with _pb
3036535 
Signed-off-by: Vigith Maurice <[email protected]>
@vigith
doc: comments
085b648 
Signed-off-by: Vigith Maurice <[email protected]>
@vigith
chore: cargo fmt
79285a8 
Signed-off-by: Vigith Maurice <[email protected]>
@vigith vigith marked this pull request as ready for review September 26, 2024 16:51
vigith
vigith approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@vigith vigith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to refactor the task to stream relationship. we can do it in a follow-up PR.

@vigith vigith merged commit 981a0a8 into main Sep 26, 2024
2 checks passed
@vigith vigith deleted the bidi-sink branch September 26, 2024 16:52
@vigith vigith mentioned this pull request Sep 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vigith vigith vigith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yhl25 @vigith