Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: buffer channels for better performance #72

Merged
merged 3 commits into from
Sep 4, 2024
Merged

chore: buffer channels for better performance #72

merged 3 commits into from
Sep 4, 2024

Conversation

yhl25
Copy link
Contributor

@yhl25 yhl25 commented Sep 3, 2024

No description provided.

@yhl25 yhl25 requested review from vigith and BulkBeing September 3, 2024 05:15
src/source.rs Outdated
@@ -15,6 +15,7 @@ use tonic::{async_trait, Request, Response, Status};
const DEFAULT_MAX_MESSAGE_SIZE: usize = 64 * 1024 * 1024;
const DEFAULT_SOCK_ADDR: &str = "/var/run/numaflow/source.sock";
const DEFAULT_SERVER_INFO_FILE: &str = "/var/run/numaflow/sourcer-server-info";
const DEFAULT_CHANNEL_SIZE: usize = 1000;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be batch size?

src/sink.rs Show resolved Hide resolved
Signed-off-by: Vigith Maurice <[email protected]>
@vigith vigith merged commit 4a5a393 into main Sep 4, 2024
2 checks passed
@vigith vigith deleted the buffer branch September 4, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants