feat: improve sink SDK experience #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vigith Maurice <[email protected]>
Signed-off-by: Vigith Maurice <[email protected]>
Signed-off-by: Vigith Maurice <[email protected]>
vigith
changed the title
BulkBeing
reviewed
Feb 18, 2024
examples/sink-log/src/main.rs
Outdated
| success: true, | ||
| err: "".to_string(), | ||
| } | ||
| struct Logger {} |
There was a problem hiding this comment.
For 'empty' struct, we can use unit struct:
struct Logger;
// value is same
sink::Server::new(Logger).start().await
BulkBeing
reviewed
Feb 18, 2024
src/map.rs
Outdated
| @@ -127,7 +127,7 @@ pub struct Server<T> { | |||
| map_svc: Option<T>, | |||
| } | |||
|
|
|||
| impl<T> Server<T> { | |||
| impl<T: Mapper> Server<T> { | |||
There was a problem hiding this comment.
In Rust, usually trait bounds are specified at the locations where it is needed. Here, it would be the start and start_with_shutdown methods. If we are moving the trait bounds to full implementation block itself, let's remove it from the where clause of those methods and make T: Mapper + Send + Sync + 'static
BulkBeing
reviewed
Feb 18, 2024
src/sink.rs
Outdated
| @@ -29,43 +32,37 @@ pub trait Sinker { | |||
| /// A simple log sink. | |||
| /// | |||
| /// ```rust,ignore | |||
There was a problem hiding this comment.
Let's make this
```no_run
to ensure code is valid and compiles.
Also, a few lines above, the doc comment still refers to the old Datum struct
/// The sink handle is given a stream of [`Datum`].
Signed-off-by: Vigith Maurice <[email protected]>
Signed-off-by: Vigith Maurice <[email protected]>
Signed-off-by: Vigith Maurice <[email protected]>
Signed-off-by: Vigith Maurice <[email protected]>
Signed-off-by: Vigith Maurice <[email protected]>
BulkBeing
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.