feat: Map Streamer #109
Merged
feat: Map Streamer #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
vigith
approved these changes
Dec 19, 2024
BulkBeing
reviewed
Dec 19, 2024
numaflow/src/mapstream.rs
Outdated
| /// use numaflow::map::Message; | ||
| /// let message = Message::new(vec![1, 2, 3]).keys(vec!["key1".to_string(), "key2".to_string()]); | ||
| /// ``` | ||
| pub fn keys(mut self, keys: Vec<String>) -> Self { |
There was a problem hiding this comment.
use with_ prefix for methods that set the member fields and return Self, like with_keys(), with_tags()
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Yashash H L <[email protected]> Co-authored-by: Vigith Maurice <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
vigith
approved these changes
Dec 20, 2024
BulkBeing
approved these changes
Dec 20, 2024
Signed-off-by: Yashash H L <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #108