Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: abstract gRPC server #156

Merged
merged 6 commits into from
Nov 8, 2024

.

f66bf9f
Select commit
Loading
Failed to load commit list.
Merged

refactor: abstract gRPC server #156

.
f66bf9f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 7, 2024 in 0s

No report found to compare against

View this Pull Request on Codecov

No report found to compare against

Details

Codecov Report

Attention: Patch coverage is 65.26316% with 66 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@ea910b3). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...io/numaproj/numaflow/shared/GrpcServerWrapper.java 55.00% 15 Missing and 3 partials ⚠️
.../main/java/io/numaproj/numaflow/mapper/Server.java 64.70% 4 Missing and 2 partials ⚠️
...main/java/io/numaproj/numaflow/sourcer/Server.java 64.70% 4 Missing and 2 partials ⚠️
...io/numaproj/numaflow/sourcetransformer/Server.java 64.70% 4 Missing and 2 partials ⚠️
...va/io/numaproj/numaflow/reducestreamer/Server.java 64.28% 3 Missing and 2 partials ⚠️
...va/io/numaproj/numaflow/sessionreducer/Server.java 64.28% 3 Missing and 2 partials ⚠️
...in/java/io/numaproj/numaflow/sideinput/Server.java 64.28% 3 Missing and 2 partials ⚠️
...main/java/io/numaproj/numaflow/reducer/Server.java 66.66% 3 Missing and 1 partial ⚠️
.../java/io/numaproj/numaflow/mapstreamer/Server.java 80.00% 3 Missing ⚠️
.../java/io/numaproj/numaflow/batchmapper/Server.java 87.50% 2 Missing ⚠️
... and 3 more
Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #156   +/-   ##
=======================================
  Coverage        ?   58.74%           
  Complexity      ?      384           
=======================================
  Files           ?      127           
  Lines           ?     2831           
  Branches        ?      179           
=======================================
  Hits            ?     1663           
  Misses          ?     1052           
  Partials        ?      116

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov