Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to supported chainID #605

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

theref
Copy link
Contributor

@theref theref commented Dec 16, 2024

No description provided.

@theref theref requested a review from derekpierre December 16, 2024 16:04
Copy link

netlify bot commented Dec 16, 2024

Deploy Preview for taco-demo canceled.

Name Link
🔨 Latest commit 31983d8
🔍 Latest deploy log https://app.netlify.com/sites/taco-demo/deploys/6762d0e017ed390008684d0a

Copy link

netlify bot commented Dec 16, 2024

Deploy Preview for taco-nft-demo canceled.

Name Link
🔨 Latest commit 31983d8
🔍 Latest deploy log https://app.netlify.com/sites/taco-nft-demo/deploys/6762d0e0c5766d000802ecc9

@theref theref force-pushed the supported_chain branch 2 times, most recently from 1c286e3 to aed6ab0 Compare December 16, 2024 16:46
@codecov-commenter
Copy link

codecov-commenter commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (epic-v0.6.x@529eee7). Learn more about missing BASE report.

Additional details and impacted files
@@              Coverage Diff               @@
##             epic-v0.6.x     #605   +/-   ##
==============================================
  Coverage               ?   88.98%           
==============================================
  Files                  ?       73           
  Lines                  ?     6539           
  Branches               ?      350           
==============================================
  Hits                   ?     5819           
  Misses                 ?      684           
  Partials               ?       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@derekpierre derekpierre mentioned this pull request Dec 17, 2024
23 tasks
derekpierre
derekpierre previously approved these changes Dec 18, 2024
Copy link
Member

@derekpierre derekpierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎸

@derekpierre derekpierre changed the base branch from main to epic-v0.6.x December 18, 2024 13:46
@derekpierre
Copy link
Member

derekpierre commented Dec 18, 2024

@theref - just realized the base branch was main and I changed it to the epic. Can you rebase over epic-v0.6.x?

@derekpierre derekpierre self-requested a review December 18, 2024 13:47
@derekpierre derekpierre dismissed their stale review December 18, 2024 16:51

Needs rebase

@theref theref force-pushed the supported_chain branch 2 times, most recently from d238e35 to c4a5be9 Compare December 19, 2024 16:15
Copy link
Member

@derekpierre derekpierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎸

@derekpierre derekpierre merged commit 6baef32 into nucypher:epic-v0.6.x Dec 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants