Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heatmap & AreaGraph Legends #434

Open
chaitanyahalbe opened this issue Dec 17, 2020 · 17 comments
Open

Heatmap & AreaGraph Legends #434

chaitanyahalbe opened this issue Dec 17, 2020 · 17 comments
Assignees

Comments

@chaitanyahalbe
Copy link
Contributor

chaitanyahalbe commented Dec 17, 2020

@nxanil

  1. There was a request from PLM to display all values from the heatmapColor object in a Heatmap visualization in the legend, unlike right now which displays the legend according to the values present in the heatmap.

  2. a. Move the Heatmap and AreaGraph legend so that it is placed slightly on the right side from where the y-axis is so that it is placed below the graphs

  3. b. Reduce the spacing between the legend items
    image
    image

cc @killanch

@chaitanyahalbe chaitanyahalbe added enhancement New feature or request Critical labels Dec 17, 2020
@chaitanyahalbe chaitanyahalbe changed the title Heatmap Legend Heatmap & AreaGraph Legends Dec 18, 2020
@nxanil
Copy link
Collaborator

nxanil commented Dec 22, 2020

@chaitanyahalbe @killanch

Please suggest which one is correct.

test

test2

@killanch
Copy link
Contributor

killanch commented Jan 5, 2021

@nxanil Option 2 above is preferable.
@chaitanyahalbe Can you pls confirm?

@chaitanyahalbe
Copy link
Contributor Author

@nxanil @killanch Yes, option 2 looks much better.

@sreddy80
Copy link

sreddy80 commented Jan 20, 2021

@nxanil - Time values and legends are not displayed properly on the below heatmap. Verified in chrome and firefox browsers
image

c: @killanch @chaitanyahalbe

@killanch
Copy link
Contributor

@nxanil can you pls check this?

@killanch
Copy link
Contributor

@sreddy80 this issue has been fixed today, could you pls validate the fix in next current build?

@killanch
Copy link
Contributor

killanch commented Feb 2, 2021

@sreddy80 any update on this?

@sreddy80
Copy link

sreddy80 commented Feb 3, 2021

@killanch - This verification is still pending due to issues with the setup bring up.

@sreddy80
Copy link

sreddy80 commented Feb 8, 2021

@killanch - this fix is not in 20.10 build.
cc: @chaitanyahalbe

@killanch
Copy link
Contributor

killanch commented Feb 9, 2021

@sreddy80 Can you pls confirm if the fix working as expected in 0.0?
@chaitanyahalbe can you pls make a back-port PR for r20.10? we will merge once 0.0 tests are completed. pls raise a JIRA ticket for tracking if one does not exist already

@chaitanyahalbe
Copy link
Contributor Author

chaitanyahalbe commented Feb 10, 2021

@chaitanyahalbe can you pls make a back-port PR for r20.10? we will merge once 0.0 tests are completed. pls raise a JIRA ticket for tracking if one does not exist already

@killanch PR is open for review #447

@sreddy80
Copy link

sreddy80 commented Feb 10, 2021

@sreddy80 Can you pls confirm if the fix working as expected in 0.0?
@chaitanyahalbe can you pls make a back-port PR for r20.10? we will merge once 0.0 tests are completed. pls raise a JIRA ticket for tracking if one does not exist already

@killanch @chaitanyahalbe - I do not see this fix in 0.0. Verified with latest build. I'm referring to below fix

image

@killanch
Copy link
Contributor

@chaitanyahalbe could you pls check this and provide an overall status summary on 0.0 and r20.10? thanks.

@chaitanyahalbe
Copy link
Contributor Author

@killanch I verified that the above PRs have been merged in 0.0 and sub-module is up-to-date. Opened up PR https://github.com/nuagenetworks/vsd-react-ui/pull/4904 to update vis-graphs in 20.10.

@killanch
Copy link
Contributor

@sreddy80 can you pls verify the fix on r20.10. @chaitanyahalbe has back-ported the fixes.

@killanch
Copy link
Contributor

@sreddy80 any update on this?

@sreddy80
Copy link

@killanch @chaitanyahalbe - I re-verified the fix on r20.10 latest build. Do not see the fix with chrome default zoom level set to 100%.
Note: Graph appears fine with zoom default level set < 100%

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants