Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix]: Heatmap graph legend and xAxis ticks issue #439

Merged
merged 1 commit into from
Jan 27, 2021

Conversation

nxanil
Copy link
Collaborator

@nxanil nxanil commented Jan 21, 2021

@killanch @chaitanyahalbe @sreddy80

Fixed issue #434. Please check once. This issue happened because of this #435

heatmapGraph

@killanch killanch requested a review from a team January 21, 2021 16:19
Copy link
Contributor

@killanch killanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nxanil looks good to me. have you checked against other graph types as well? lets make sure legends get rendered correctly on all applicable graph types

@nxanil
Copy link
Collaborator Author

nxanil commented Jan 22, 2021

@nxanil looks good to me. have you checked against other graph types as well? lets make sure legends get rendered correctly on all applicable graph types

@killanch
Only the heatmap graph is using d3 graph. Other graphs are using Recharts. That's why this issue happened in the heatmap graph because the heatmap graph used d3 ticks.

@nxanil nxanil merged commit 42acb80 into master Jan 27, 2021
@chaitanyahalbe chaitanyahalbe deleted the bug/heatmap-legend-issue branch February 11, 2021 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants