Allowing clients to pass an empty list of children to assign #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-leclerc
suggested changes
Apr 6, 2017
| @@ -203,10 +203,15 @@ public void instantiateChild(RestObject restObj, RestObject childRestObj, RestOb | |||
|
|
|||
| @Override | |||
| public void assign(RestObject restObj, List<? extends RestObject> childRestObjs) throws RestException { | |||
| restObj.assign(this, childRestObjs); | |||
| assign(restObj, childRestObjs, null); | |||
There was a problem hiding this comment.
For consistency, this line should read: restObj.assign(this, childRestObjs) or restObj.assign(this, childRestObjs, null);
|
|
||
| void assign(List<? extends RestObject> childRestObjs, boolean commit) throws RestException; | ||
|
|
||
There was a problem hiding this comment.
Remove extra spaces. Fairly minor :-)
| @@ -53,9 +53,11 @@ | |||
| void instantiateChild(RestObject childRestObj, RestObject fromTemplate, Integer responseChoice, boolean commit) throws RestException; | |||
|
|
|||
| void assign(List<? extends RestObject> childRestObjs) throws RestException; | |||
|
|
|||
| void assign(List<? extends RestObject> childRestObjs, Class<? extends RestObject> objectType) throws RestException; | |||
| restObj.assign(this, childRestObjs, objectType); | ||
| } | ||
|
|
||
| @Override |
| } else { | ||
| throw new RestException("Session not available in current thread"); | ||
| } | ||
| } | ||
|
|
||
| @Override | ||
| public void assign(List<? extends RestObject> childRestObjs) throws RestException { |
| RestSession<?> session = RestSession.getCurrentSession(); | ||
| if (session != null) { | ||
| session.assign(this, childRestObjs); | ||
| session.assign(this, childRestObjs, objectType); |
| @@ -212,16 +212,21 @@ public void instantiateChild(RestObject childRestObj, RestObject fromTemplate, I | |||
| } | |||
|
|
|||
| @Override | |||
| public void assign(List<? extends RestObject> childRestObjs) throws RestException { | |||
| public void assign(List<? extends RestObject> childRestObjs, Class<? extends RestObject> objectType) throws RestException { | |||
There was a problem hiding this comment.
For API backwards compatibility, the following method signature should still be supported:
public void assign(List<? extends RestObject> childRestObjs) throws RestException
|
|
||
| @Override | ||
| public void assign(RestSession<?> session, List<? extends RestObject> childRestObjs, Class<? extends RestObject> objectType) throws RestException { | ||
| assign(session, childRestObjs, objectType, true); |
|
|
||
| void assign(RestSession<?> session, List<? extends RestObject> childRestObjs, Class<? extends RestObject> objectType, boolean commit) throws RestException; | ||
|
|
||
| void assign(RestSession<?> session, List<? extends RestObject> childRestObjs, Class<? extends RestObject> objectType) throws RestException; |
| @@ -59,6 +59,8 @@ | |||
| void assign(RestObject restObj, List<? extends RestObject> childRestObjs) throws RestException; | |||
|
|
|||
| void assign(RestObject restObj, List<? extends RestObject> childRestObjs, boolean commit) throws RestException; | |||
|
|
|||
| void assign(RestObject restObj, List<? extends RestObject> childRestObjs, Class<? extends RestObject> objectType) throws RestException; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #4