Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed CBFLIB install #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

samuelmc91
Copy link

No description provided.

@samuelmc91 samuelmc91 closed this Feb 25, 2022
@yayahjb
Copy link

yayahjb commented Feb 26, 2022

Looks good except for two small problems.
The pull request is closed instead of open
The make file now will only work with a cbflib that has been installed in /lib (i.e. as a system install). You should also allow the possibility of cbflib been somewhere else, e.g. /usr/local/lib, /opt/local/lib,
/lib64, $HOME/lib, ... etc, i.e. you should make the path to CBFlib symbolic, rather than hard-wired.
I am going to reopen and comment.

@yayahjb yayahjb reopened this Feb 26, 2022
@yayahjb
Copy link

yayahjb commented Feb 26, 2022

Now it is open. If you make the cbflib library location symbolic, it should be ready to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants