fix: state machine improvements and error handling (SOFIE-3751) #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…her expectation, loop through fullfilled->new->waiting->fullfilled statuses. This was caused by the WAITING state didn't check if the expectaiton was waiting for another BEFORE checking if it was fulfilled. But the FULFILLED state did.
… out of a WorkInProgress.
nytamin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About Me
This pull request is posted on behalf of the NRK.
Type of Contribution
This is a: Bug fix
Current Behavior
We saw a situation in production that PM was not handling very well.
Issue A:
There was an expectation that throw in workOnExpectation with error:
And PM reported the errors as bad status, which didn't look too good.
Issue B:
Expectations that are fulfilled but are waiting for another expectation get stuck in a state loop
fullfilled->new->waiting->fullfilled.New Behavior
PM will handle the issues more gracefully.
Issue A: Expectations will stay in WAITING state when the Quantel clip is not found, without throwing errors.
Issue B: Those expectations will not loop through the states anymore.
Testing Instructions
Other Information
Status