Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/main not updated sofie 3067 #100

Merged
merged 3 commits into from
Apr 30, 2024
Merged

Conversation

mint-dewit
Copy link
Contributor

About the Contributor

This PR is on behalf of NRK

Type of Contribution

This is a bug fix

Current Behavior

If the primary is blocked but connected sofie will keep trying to send data to the primary.

New Behavior

If the primary is blocked but connected sofie will use the buddy instead.

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

@mint-dewit mint-dewit requested a review from a team April 30, 2024 07:02
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 75.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 77.70%. Comparing base (dcf23cb) to head (a155d24).
Report is 1 commits behind head on master.

Files Patch % Lines
packages/connector/src/MosDevice.ts 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #100      +/-   ##
==========================================
+ Coverage   77.51%   77.70%   +0.18%     
==========================================
  Files          65       65              
  Lines        3594     3638      +44     
  Branches      838      856      +18     
==========================================
+ Hits         2786     2827      +41     
+ Misses        784      752      -32     
- Partials       24       59      +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mint-dewit mint-dewit merged commit ffb8bf6 into master Apr 30, 2024
21 checks passed
@mint-dewit mint-dewit deleted the fix/main-not-updated-SOFIE-3067 branch April 30, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants