Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support test-framework v1.4.5 #97

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Support test-framework v1.4.5 #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
31d70eb
Pin test-framework version to v1.4.5
nowsprinting Sep 3, 2024
a32545b
Ignore tests that use WaitForEndOfFrame run tests on batchmode
nowsprinting Sep 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ jobs:
- name: Install dependencies
run: |
npm install -g openupm-cli
openupm add -f [email protected].4
openupm add -f [email protected].5
openupm add -f com.unity.testtools.codecoverage
openupm add -f com.cysharp.unitask
working-directory: ${{ env.CREATED_PROJECT_PATH }}
Expand Down
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ create_project:
-batchmode \
-quit
touch UnityProject~/Assets/.gitkeep
openupm -c $(PROJECT_HOME) add -f [email protected].4
openupm -c $(PROJECT_HOME) add -f [email protected].5
openupm -c $(PROJECT_HOME) add -f com.unity.testtools.codecoverage
openupm -c $(PROJECT_HOME) add -f com.cysharp.unitask
openupm -c $(PROJECT_HOME) add -ft $(PACKAGE_NAME)@file:../../
Expand Down
2 changes: 2 additions & 0 deletions Tests/Runtime/Attributes/GizmosShowOnGameViewAttributeTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,8 @@ public async Task AttachToAsyncTest_ShowGizmos()
await Task.Yield();
}

[IgnoreBatchMode(
"The following error occurred since UTF v1.4.5: UnityTest yielded WaitForEndOfFrame, which is not evoked in batchmode.")]
[UnityTest]
[CreateScene(camera: true, light: true)]
[GizmosShowOnGameView]
Expand Down
4 changes: 4 additions & 0 deletions Tests/Runtime/Attributes/TakeScreenshotAttributeTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,8 @@ public void AttachToAsyncTest_SaveScreenshotToDefaultPath_ExistFile()
Assert.That(new FileInfo(path), Has.Length.GreaterThan(FileSizeThreshold));
}

[IgnoreBatchMode(
"The following error occurred since UTF v1.4.5: UnityTest yielded WaitForEndOfFrame, which is not evoked in batchmode.")]
[UnityTest, Order(0)]
[LoadScene(TestScene)]
[TakeScreenshot]
Expand All @@ -107,6 +109,8 @@ public IEnumerator AttachToUnityTest_SaveScreenshotToDefaultPath()
// Take screenshot after running the test.
}

[IgnoreBatchMode(
"The following error occurred since UTF v1.4.5: UnityTest yielded WaitForEndOfFrame, which is not evoked in batchmode.")]
[Test, Order(1)]
public void AttachToUnityTest_SaveScreenshotToDefaultPath_ExistFile()
{
Expand Down