Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mod run tests as embedded package on CI #71

Merged
merged 2 commits into from
Apr 28, 2024

Conversation

nowsprinting
Copy link
Owner

@nowsprinting nowsprinting commented Apr 28, 2024

Changes

Fix paths in .octocov.yml

  • Fix code coverage store directory when running via Makefile.
  • RuntimeInternals were not counted in the "Code to Test Ratio" setting.

Mod run tests as embedded package on CI

In Linux editor, there is a problem that assets in local packages cannot be found with AssetDatabase.FindAssets. Refs: #66
As a workaround, I have made it into an embedded package.

@github-actions github-actions bot added the chore label Apr 28, 2024

This comment has been minimized.

@nowsprinting nowsprinting marked this pull request as draft April 28, 2024 13:13
@nowsprinting nowsprinting force-pushed the chore/fix_test_workflow branch from 5c7f9f0 to 3e84e8f Compare April 28, 2024 13:20

This comment has been minimized.

In Linux editor, there is a problem that assets in local packages cannot be found with `AssetDatabase.FindAssets`.
As a workaround, I have made it into an embedded package.
@nowsprinting nowsprinting force-pushed the chore/fix_test_workflow branch from 3e84e8f to d270be7 Compare April 28, 2024 13:34
Copy link

Code Metrics Report

master (eebba86) #71 (10ec3d1) +/-
Coverage 66.8% 66.8% 0.0%
Code to Test Ratio 1:2.0 1:1.1 -1.0
Details
  |                    | master (eebba86) | #71 (10ec3d1) | +/-  |
  |--------------------|------------------|---------------|------|
  | Coverage           |            66.8% |         66.8% | 0.0% |
  |   Files            |               24 |            24 |    0 |
  |   Lines            |              548 |           548 |    0 |
  |   Covered          |              366 |           366 |    0 |
- | Code to Test Ratio |            1:2.0 |         1:1.1 | -1.0 |
  |   Code             |              543 |          1046 | +503 |
  |   Test             |             1103 |          1103 |    0 |

Reported by octocov

@nowsprinting nowsprinting marked this pull request as ready for review April 28, 2024 13:39
@nowsprinting nowsprinting merged commit 8f12462 into master Apr 28, 2024
9 checks passed
@nowsprinting nowsprinting deleted the chore/fix_test_workflow branch April 28, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant