Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mod SceneManagerHelper.LoadSceneAsync return type to AsyncOperation #114

Merged
merged 2 commits into from
Jan 5, 2025

Conversation

nowsprinting
Copy link
Owner

Before

IEnumerator

After

AsyncOperation

@Copilot Copilot bot review requested due to automatic review settings January 5, 2025 18:28
@github-actions github-actions bot added the bug Something isn't working label Jan 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Copy link

github-actions bot commented Jan 5, 2025

Code Metrics Report

master (4f00648) #114 (61f60ba) +/-
Coverage 78.7% 78.7% 0.0%
Code to Test Ratio 1:0.7 1:0.7 +0.0
Test Execution Time 4m17s 4m24s +7s
Details
  |                     | master (4f00648) | #114 (61f60ba) | +/-  |
  |---------------------|------------------|----------------|------|
  | Coverage            |            78.7% |          78.7% | 0.0% |
  |   Files             |               35 |             35 |    0 |
  |   Lines             |             1064 |           1064 |    0 |
  |   Covered           |              838 |            838 |    0 |
+ | Code to Test Ratio  |            1:0.7 |          1:0.7 | +0.0 |
  |   Code              |             1860 |           1859 |   -1 |
  |   Test              |             1448 |           1448 |    0 |
- | Test Execution Time |            4m17s |          4m24s |  +7s |

Code coverage of files in pull request scope (93.8% → 93.8%)

Files Coverage +/-
RuntimeInternals/SceneManagerHelper.cs 93.8% 0.0%

Reported by octocov

@nowsprinting nowsprinting changed the title Fix return type of SceneManagerHelper.LoadSceneAsync to AsyncOperation Fix SceneManagerHelper.LoadSceneAsync return type to AsyncOperation Jan 5, 2025
@nowsprinting nowsprinting merged commit 4f78186 into master Jan 5, 2025
14 checks passed
@nowsprinting nowsprinting deleted the fix/asyncoperation_loadsceneasync branch January 5, 2025 18:52
@nowsprinting nowsprinting changed the title Fix SceneManagerHelper.LoadSceneAsync return type to AsyncOperation Mod SceneManagerHelper.LoadSceneAsync return type to AsyncOperation Jan 5, 2025
@nowsprinting nowsprinting added enhancement New feature or request and removed bug Something isn't working labels Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant