Add command line argument to specify screenshot save directory #97
+17
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before: Application.persistentDataPath+/TestHelper.Monkey/Screenshots After: 1. command line argument "-testHelperScreenshotDirectory" 2. Application.persistentDataPath+/TestHelper/Screenshots
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
nowsprinting
force-pushed
the
feature/screenshotpath
branch
from
8dd2d0b to
46174ed
Compare
This comment has been minimized.
This comment has been minimized.
nowsprinting
force-pushed
the
feature/screenshotpath
branch
from
46174ed to
f672075
Compare
Code Metrics Report
Details | | master (765ed1b) | #97 (e3704a5) | +/- |
|---------------------|------------------|---------------|-------|
- | Coverage | 76.8% | 76.7% | -0.1% |
| Files | 29 | 29 | 0 |
| Lines | 630 | 627 | -3 |
- | Covered | 484 | 481 | -3 |
+ | Code to Test Ratio | 1:1.2 | 1:1.2 | +0.0 |
| Code | 1303 | 1299 | -4 |
- | Test | 1615 | 1614 | -1 |
- | Test Execution Time | 4m21s | 4m25s | +4s |Code coverage of files in pull request scope (100.0% → 100.0%)
Reported by octocov |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the default screenshot save directory.
This feature is inherited from test-helper v0.5. see: nowsprinting/test-helper#63
Before:
Application.persistentDataPath+/TestHelper.Monkey/Screenshots
After:
First, command line argument "-testHelperScreenshotDirectory".
If the command line argument is omitted, Application.persistentDataPath + "/TestHelper/Screenshots/" is used. (removed
.Monkey)