Restrict lookup for new item template to the closest item if exists #62
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #61.
When a form uses Cocooned on multiple nested levels, the name data attribute of the template used to build new grand-child item does not change between child item (as all where built from the same template). If multiple child item are added to the form at the same time and each contains an add trigger to build new grand-child items, they will all share the same template name.
So far, lookup was done with
document.querySelector
but this will always return the first template with a matching name, the one of the first built child item. The options extractor will now look only inside the closest cocooned item to find the template and instantiate a builder with the correct template.As a fallback, if no template is found, it will still look through the whole document so top-level Cocooned instance can still have their add triggers (and their associated template) anywhere.