Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make cocooned wrappers support custom tag name #56

Merged
merged 3 commits into from
Jan 28, 2024
Merged

Make cocooned wrappers support custom tag name #56

merged 3 commits into from
Jan 28, 2024

Conversation

gael-ian
Copy link
Member

Add support for tag name as first argument on concooned_container and cocooned_item helpers, just as ActionView's content_tag do.

cocooned_container # <div data-cocooned-container></div>
cocooned_container(:span) # <span data-cocooned-container></span>

This should fix #55.

@gael-ian gael-ian mentioned this pull request Jan 22, 2024
Closed
@gael-ian gael-ian merged commit 3f96bc3 into main Jan 28, 2024
13 checks passed
@gael-ian gael-ian deleted the cocooned-wrappers-with-optionnal-tag branch January 28, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Make cocooned_item support HTML table tag
1 participant
@gael-ian