forked from ManifoldScholar/manifold
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i3 Replace sockets with ports #29
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Rob Kaufman <[email protected]>
2a82215
to
0496070
Compare
c46291a
to
a21e87f
Compare
This follows convention set in other projects, like PALs
aprilrieger
approved these changes
Aug 20, 2024
aprilrieger
approved these changes
Aug 20, 2024
abb380c 'remove SSL from nginx conf, restore nginx commands'
This should allow nginx to start both locally and in prod. The self-signed certs will be generated in both, but since we have SSL at the ingress level in prod, they will be vestigial in prod
It needed an argument
aprilrieger
approved these changes
Aug 20, 2024
aprilrieger
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref:
TODO
service.yaml
and test deployment (is it required?)