♻️ Remove conditionals and account for Valkyrie #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShanaLMoore
approved these changes
Jan 23, 2024
The `IiifPrint.model_configuration` is something we use to create a module that we mixin to a model; either `ActiveFedor::Base` or `Valkyrie::Resource`. As such we know when the model is configured for IiifPrint. It follows that we can remove the `iiif_print_config?` methods. Further, to account for Valkyrie indexers favoring the `#to_solr` method and ActiveFedora indexers favoring `#generate_solr_document` we introduce a bit of sleuthing to see which type we have. But also concede that if you've implemented either method we're going to duplicate that behavior. So we get to remove one module and two methods; and remove a potential timing issue regarding when we mixing the model_configuration and when we loop through the work_types to include additional logic.
jeremyf
force-pushed
the
refactoring-configurations
branch
from
3b6573b to
1c3ea71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
IiifPrint.model_configurationis something we use to create a module that we mixin to a model; eitherActiveFedor::BaseorValkyrie::Resource.As such we know when the model is configured for IiifPrint. It follows that we can remove the
iiif_print_config?methods.Further, to account for Valkyrie indexers favoring the
#to_solrmethod and ActiveFedora indexers favoring#generate_solr_documentwe introduce a bit of sleuthing to see which type we have. But also concede that if you've implemented either method we're going to duplicate that behavior.So we get to remove one module and two methods; and remove a potential timing issue regarding when we mixing the model_configuration and when we loop through the work_types to include additional logic.