♻️ Preparing Splitter Service Swap for DerivativeRodeo #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is a refactor in-place. The primary goal is to allow for passing the file_set to the child works; something that is ideal for the derivative rodeo's interface. This is intended to be a swap-in-place change. That is to say, if we deploy this change and have already enqueued jobs, nothing will fail nor break. The past enqueued jobs (with a work) will use the work based logic but future enqueueings will use file_set. In using the file_set, we also avoid the issue of having passing a `nil` as the parent, and thus creating an infinite rescheduling cycle. Related to: - #220
kirkkwang
reviewed
May 30, 2023
kirkkwang
reviewed
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is a refactor in-place. The primary goal is to allow for passing the file_set to the child works; something that is ideal for the derivative rodeo's interface.
This is intended to be a swap-in-place change. That is to say, if we deploy this change and have already enqueued jobs, nothing will fail nor break. The past enqueued jobs (with a work) will use the work based logic but future enqueueings will use file_set.
In using the file_set, we also avoid the issue of having passing a
nilas the parent, and thus creating an infinite rescheduling cycle.Related to:
Story
Refs #issuenumber
Expected Behavior Before Changes
Expected Behavior After Changes
Screenshots / Video
Notes