Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update knapsack with prime #176

Merged
merged 5 commits into from
Mar 15, 2024
Merged

Update knapsack with prime #176

merged 5 commits into from
Mar 15, 2024

Conversation

laritakr
Copy link
Contributor

Story

Bring in several knapsack prime changes.

kirkkwang and others added 5 commits March 14, 2024 16:19
This is a quality of life improvement.  Use this generator to create a
new work type in the Knapsack because using the Hyrax work generator
will create files in the submodule and we don't want that.

```sh
rails generate hyku_knapsack:work WorkType
```
This decorator needs to be in play for the work types to load their
respective yaml files.
🎁 Add SimpleSchemaLoaderDecorator for work types
Copy link
Contributor

@kirkkwang kirkkwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@laritakr laritakr merged commit 2030818 into main Mar 15, 2024
7 checks passed
@laritakr laritakr deleted the update_knapsack_with_prime branch March 15, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants