♻️ Flattening assumptive dir structure for PDFs #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yes, it would be nice to have sub-directories for pages ripped from a PDF. However, that aspirational state creates complications on the implementation details of the DerivativeRodeo; by moving from a tail glob to a regular expression, we create a more powerful mechanism for finding files. These changes also highlighted a few implementation bugs (namely ensuring the correct expected return value of the newly re-named function). In IIIF Print we still need to consider how to find the child page's derivatives of an original PDF. That is, however, not a problem for this repository. Related to: - notch8/iiif_print#251 Co-authored-by: Kirk Wang <[email protected]>
kirkkwang
approved these changes
Jun 6, 2023
jeremyf
added a commit
to notch8/iiif_print
that referenced
this pull request
Jun 6, 2023
This commit leverages the conventions established in the DerivativeRodeo around where we're writing split pages and their derivatives. The inline comments that are written/amended with this PR should be read closely for clarity and intention. Related to: - #251 - notch8/derivative_rodeo#48 Co-authored-by: Kirk Wang <[email protected]>
jeremyf
added a commit
to notch8/iiif_print
that referenced
this pull request
Jun 6, 2023
This commit leverages the conventions established in the DerivativeRodeo around where we're writing split pages and their derivatives. The inline comments that are written/amended with this PR should be read closely for clarity and intention. Related to: - #251 - notch8/derivative_rodeo#48 Co-authored-by: Kirk Wang <[email protected]>
jeremyf
added a commit
to notch8/iiif_print
that referenced
this pull request
Jun 6, 2023
This commit leverages the conventions established in the DerivativeRodeo around where we're writing split pages and their derivatives. The inline comments that are written/amended with this PR should be read closely for clarity and intention. Related to: - #251 - notch8/derivative_rodeo#48 Co-authored-by: Kirk Wang <[email protected]>
jeremyf
added a commit
to notch8/iiif_print
that referenced
this pull request
Jun 6, 2023
This commit leverages the conventions established in the DerivativeRodeo around where we're writing split pages and their derivatives. The inline comments that are written/amended with this PR should be read closely for clarity and intention. Related to: - #251 - notch8/derivative_rodeo#48 Co-authored-by: Kirk Wang <[email protected]>
jeremyf
added a commit
to notch8/iiif_print
that referenced
this pull request
Jun 7, 2023
This commit leverages the conventions established in the DerivativeRodeo around where we're writing split pages and their derivatives. The inline comments that are written/amended with this PR should be read closely for clarity and intention. Related to: - #251 - notch8/derivative_rodeo#48 Co-authored-by: Kirk Wang <[email protected]>
jeremyf
added a commit
to notch8/iiif_print
that referenced
this pull request
Jul 7, 2023
This commit leverages the conventions established in the DerivativeRodeo around where we're writing split pages and their derivatives. The inline comments that are written/amended with this PR should be read closely for clarity and intention. Related to: - #251 - notch8/derivative_rodeo#48 Co-authored-by: Kirk Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yes, it would be nice to have sub-directories for pages ripped from a PDF. However, that aspirational state creates complications on the implementation details of the DerivativeRodeo; by moving from a tail glob to a regular expression, we create a more powerful mechanism for finding files.
These changes also highlighted a few implementation bugs (namely ensuring the correct expected return value of the newly re-named function).
In IIIF Print we still need to consider how to find the child page's derivatives of an original PDF. That is, however, not a problem for this repository.
Related to: