Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit content search #200

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

asedeno
Copy link
Collaborator

@asedeno asedeno commented Sep 20, 2021

As per the haystack documentation [1] the content field is a special term for the field marked document=True. This change implements that behavior.

[1] https://django-haystack.readthedocs.io/en/master/searchqueryset_api.html#the-content-shortcut

This reopens #182 on a topic branch.

NB: This has been rebased onto master as of now, but has not been re-tested at all. Consider it a draft starting point to consider the issue.

@asedeno asedeno marked this pull request as draft September 20, 2021 15:55
As per the haystack documentation [1] the `content` field is a special
term for the field marked `document=True`. This change impements that
behavior.

[1] https://django-haystack.readthedocs.io/en/master/searchqueryset_api.html#the-content-shortcut
@asedeno asedeno force-pushed the limit-content-search branch from 1d3be9d to b2f2ba3 Compare September 27, 2021 04:40
@asedeno
Copy link
Collaborator Author

asedeno commented Sep 27, 2021

Rebased so we can get all the test coverage stuff running on the branch.

As mentioned in the previous iteration of this PR, it breaks tests. I believe those tests are broken by design because the content field was being misused. That said, fixing it would not be backwards compatible, so doing so probably warrants a new major version or something. I'm not sure when I'll get around to examining the broken tests yet though, so for now this should linger as a draft unless someone else wants to work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant