Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ask_slot when there is a single slot #2

Merged
merged 2 commits into from
Apr 30, 2024

Conversation

leiserfg
Copy link
Contributor

No description provided.

@not-a-feature
Copy link
Owner

Thanks for pointing this out.
I fixed your change s.t. is is clearly visible that the current slot is returned aswell. (Even though in this special case it is identical to the selected slot)

@not-a-feature not-a-feature merged commit adb6080 into not-a-feature:main Apr 30, 2024
1 check passed
@leiserfg
Copy link
Contributor Author

I also noticed that the url of the firmware is incorrect, I fixed it but still, I can't make the nvme to switch to the new one.

@not-a-feature
Copy link
Owner

Could you elaborate it further and provide a detailed log ( by running using the -vv flag)

@leiserfg
Copy link
Contributor Author

leiserfg commented Apr 30, 2024

this was my change

    base_url = f"{BASE_WD_DOMAIN}/firmware/{model}/{version}/"
    prop_url = f"{base_url}device_properties.xml"
...
    firmware_url = f"{base_url}{root.findtext('fwfile')}"

@leiserfg
Copy link
Contributor Author

leiserfg commented Apr 30, 2024

When I ran wd_fw_update it told me (as in my pr) that there was a single slot, but by running (after nvme download ...)
sudo nvme fw-commit -s 2 -a 0 /dev/nvme0n1
it created a slot 2 and set the firmware into that slot,
But it did not work anyway 😄

After I ran the wd_fw_update again and now the two slots where reported (with the old firmware in 1 and the new one in 2, because of my manual nvme commit). I choose mode 3, and now the firmware version is correct. Hope this helps the protect somehow.

@not-a-feature
Copy link
Owner

I still don't understand what the problem / bug is, or if there is even any.
Without model number / configuration i can't do anything.

Please reboot your device, reset wd_fw_update to its original state (uninstall, reinstall) and provide the output of wd_fw_update -vv

@leiserfg
Copy link
Contributor Author

Sorry for the annoyance, maybe the issue wasthat the mode 2 didn't work for me and the 3 did, but anyway in order to make all work I had to change the URL of the firmware as in my previous comment.

Cause it was https://wddashboarddownloads.wdc.com/wdDashboard/firmware/WD_BLACK_SN770_500GB/731120WD/731120WD.fluf and the URL in the repo is currently pointing to an URL that does not exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants