Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bucket notification - harden bad name scenario. Also, don't reply internal '_' field. #8796

Merged
merged 1 commit into from
Feb 17, 2025
Merged

bucket notification - harden bad name scenario. Also, don't reply internal '_' field. #8796

merged 1 commit into from
Feb 17, 2025

Conversation

alphaprinz
Copy link
Contributor

Explain the changes

  1. Some cases of bad user input resulted in internal error.
    Reply with an error code instead.
  2. Reply for add connection included the internal '_' field.

Issues: Fixed #xxx / Gap #xxx

  1. Connection status is throwing internal server error for non existing connection name #8794
  2. Connection delete is throwing internal server error if connection name provided doesnot exist #8793
  3. Connection add should throw proper error instead of InternalError #8792
  4. Connection add command output is not proper #8791

Testing Instructions:

  1. See issues.
  • Doc added/updated
  • Tests added

@alphaprinz alphaprinz force-pushed the notif_error_resps branch 2 times, most recently from b4cc5fb to 8e8e7bd Compare February 14, 2025 01:29
achouhan09
achouhan09 reviewed Feb 14, 2025
View reviewed changes
Copy link
Member

@achouhan09 achouhan09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only you can add tests for this.

@pull-request-size pull-request-size bot added size/L and removed size/M labels Feb 14, 2025
@alphaprinz alphaprinz merged commit 1bbd42e into noobaa:master Feb 17, 2025
11 checks passed
alphaprinz added a commit to alphaprinz/noobaa-core that referenced this pull request Feb 17, 2025
@alphaprinz
bucket notification - harden bad name scenario. Also, don't reply int…
047a88e 
…ernal '_' field. (noobaa#8796)
@alphaprinz alphaprinz mentioned this pull request Feb 17, 2025
Open
alphaprinz added a commit to alphaprinz/noobaa-core that referenced this pull request Feb 17, 2025
@alphaprinz
bucket notification - harden bad name scenario. Also, don't reply int…
117f9ad 
…ernal '_' field. (noobaa#8796)

Signed-off-by: Amit Prinz Setter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achouhan09 achouhan09 achouhan09 approved these changes

@aspandey aspandey Awaiting requested review from aspandey

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alphaprinz @achouhan09