Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting active_root_key parallel to loading key #8788

Merged
merged 1 commit into from
Feb 13, 2025
Merged

Setting active_root_key parallel to loading key #8788

merged 1 commit into from
Feb 13, 2025
+5 −5

Conversation

jackyalbo
Copy link
Contributor

Explain the changes

  1. We were waiting to load all the keys in the root secret before setting the active key. We can do it in parallel so the system can start, but loading will continue in the background.
  2. We will also limit the number of keys in the root_key secret in another PR in the operator

Issues: Fixed #xxx / Gap #xxx

  1. Fixed https://issues.redhat.com/browse/DFBUGS-1344

Testing Instructions:

  1. Follow the steps in the mentioned issue.
  • Doc added/updated
  • Tests added

@jackyalbo jackyalbo requested a review from liranmauda February 13, 2025 08:57
@jackyalbo jackyalbo merged commit 44fced5 into noobaa:master Feb 13, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liranmauda liranmauda liranmauda approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jackyalbo @liranmauda