nope-ip removal - Phase 3 #8779
Merged
+265
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liranmauda
force-pushed
the
liran-remove-node-ip
branch
3 times, most recently
from
7227447 to
138c46b
Compare
nadavMiz
reviewed
Feb 12, 2025
`stun.js`:
- Replaced `node-ip` with native `net_utils` calls
`http_utils.js`:
- Refractored `no_proxy_list`
- Replaced `node-ip.cidr` with native `net_utils.is_cidr` call
`net_utils.js`:
- Fixed a bug where `is_fqdn("loclhost")` returned falsely true
- Add `is_cidr`, `ip_toString`, and `ip_toBuffer`
- Added helper functions for `ip_toBuffer`
- Adding `test_net_utils.test.js`
Signed-off-by: liranmauda <[email protected]>
liranmauda
force-pushed
the
liran-remove-node-ip
branch
from
138c46b to
4514fb7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
stun.js:node-ipwith nativenet_utilscallshttp_utils.js:no_proxy_listnode-ip.cidrwith nativenet_utils.is_cidrcallnet_utils.js:Fixed a bug where
is_fqdn("loclhost")returned falsely trueAdd
is_cidr,ip_toString, andip_toBufferAdded helper functions for
ip_toBufferAdding
test_net_utils.test.jsSigned-off-by: liranmauda [email protected]