-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NC | CLI | Updated the CLI response to have more info when account/bucket has been deleted #8723
Merged
+35
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shirady
reviewed
Jan 26, 2025
nadavMiz
reviewed
Jan 27, 2025
552ba45
to
390d2b4
Compare
shirady
reviewed
Jan 30, 2025
romayalon
requested changes
Jan 30, 2025
390d2b4
to
7a0f9e3
Compare
7a0f9e3
to
c3c75b6
Compare
romayalon
reviewed
Feb 6, 2025
@@ -150,25 +170,30 @@ ManageCLIResponse.UpgradeHistory = Object.freeze({ | |||
|
|||
ManageCLIResponse.ConnectionCreated = Object.freeze({ | |||
code: 'ConnectionCreated', | |||
message: 'Connection has been successfully created', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that here as well maybe Notification Connection
@alphaprinz probably can help with this response details
romayalon
reviewed
Feb 6, 2025
c3c75b6
to
a0129e7
Compare
a0129e7
to
4172231
Compare
romayalon
approved these changes
Feb 10, 2025
6c75de7
to
3c632af
Compare
…en deleted and also for other operations Signed-off-by: Aayush Chouhan <[email protected]>
3c632af
to
8645ca2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
Issues: Fixed #xxx / Gap #xxx
Testing Instructions: