Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NC | CLI | Updated the CLI response to have more info when account/bucket has been deleted #8723

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

achouhan09
Copy link
Member

@achouhan09 achouhan09 commented Jan 24, 2025

Explain the changes

  1. Improved the response to provide a clearer message about the operations.
  2. Now, the name of the object would also be printed in the response message for more info.

Issues: Fixed #xxx / Gap #xxx

  1. Fixed: NC | NSFS | CLI | Improve Response (To have Details) #8200

Testing Instructions:

  1. Try creating/deleting(or any other operation) on objects(account, bucket, etc.) using noobaa-cli and check the response returned.
  • Tests added

@achouhan09 achouhan09 requested review from liranmauda, romayalon, shirady, a team and vh05 and removed request for a team January 24, 2025 14:51
src/manage_nsfs/manage_nsfs_cli_responses.js Outdated Show resolved Hide resolved
src/cmd/manage_nsfs.js Outdated Show resolved Hide resolved
src/cmd/manage_nsfs.js Outdated Show resolved Hide resolved
@achouhan09 achouhan09 force-pushed the account-res-fix branch 2 times, most recently from 552ba45 to 390d2b4 Compare January 29, 2025 10:04
src/manage_nsfs/manage_nsfs_cli_responses.js Outdated Show resolved Hide resolved
src/manage_nsfs/manage_nsfs_cli_responses.js Outdated Show resolved Hide resolved
src/manage_nsfs/manage_nsfs_cli_responses.js Outdated Show resolved Hide resolved
src/cmd/manage_nsfs.js Outdated Show resolved Hide resolved
src/manage_nsfs/manage_nsfs_cli_responses.js Outdated Show resolved Hide resolved
@@ -150,25 +170,30 @@ ManageCLIResponse.UpgradeHistory = Object.freeze({

ManageCLIResponse.ConnectionCreated = Object.freeze({
code: 'ConnectionCreated',
message: 'Connection has been successfully created',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that here as well maybe Notification Connection
@alphaprinz probably can help with this response details

src/manage_nsfs/manage_nsfs_cli_responses.js Outdated Show resolved Hide resolved
src/manage_nsfs/manage_nsfs_cli_responses.js Outdated Show resolved Hide resolved
…en deleted and also for other operations

Signed-off-by: Aayush Chouhan <[email protected]>
@achouhan09 achouhan09 merged commit 23aec8d into noobaa:master Feb 11, 2025
11 checks passed
@achouhan09 achouhan09 deleted the account-res-fix branch February 11, 2025 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NC | NSFS | CLI | Improve Response (To have Details)
4 participants