Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bucket notifications - go on to next event when checking event filters (gh issue 8652) #8659

Merged
merged 1 commit into from
Jan 7, 2025
Merged

bucket notifications - go on to next event when checking event filters (gh issue 8652) #8659

merged 1 commit into from
Jan 7, 2025

Conversation

alphaprinz
Copy link
Contributor

Explain the changes

  1. Continue to next possible event if several events filters are present in a notification configuration.

Issues: Fixed #xxx / Gap #xxx

  1. multiple events support are not working in the bucket.json/notification.json then it fails to send the event in the array #8652

Testing Instructions:

  1. See gh issue.
  • Doc added/updated
  • Tests added

@alphaprinz alphaprinz changed the title bucket notifications - go on to next event when checking event filter s (gh issue 8652) bucket notifications - go on to next event when checking event filters (gh issue 8652) Jan 7, 2025
@alphaprinz alphaprinz mentioned this pull request Jan 7, 2025
Closed
@alphaprinz alphaprinz merged commit 52887eb into noobaa:master Jan 7, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aspandey aspandey aspandey approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alphaprinz @aspandey