Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support <Type as Trait>::method in expressions #7551

Merged
merged 5 commits into from
Feb 27, 2025
Merged

feat: Support <Type as Trait>::method in expressions #7551

merged 5 commits into from
Feb 27, 2025

Conversation

jfecher
Copy link
Contributor

@jfecher jfecher commented Feb 27, 2025 •
edited
Loading

Description

Problem*

Resolves #4539

Summary*

Implements 'as trait' syntax in an expression context. It was previously only allowed for associated types.

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@jfecher jfecher requested a review from a team February 27, 2025 19:52
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Feb 27, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 27, 2025 •
edited
Loading

🚀 Deployed on https://67c0d5e1bdb9df11a69c8f28--noir-docs.netlify.app

asterite
asterite approved these changes Feb 27, 2025
View reviewed changes
Copy link
Collaborator

@asterite asterite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I left a couple of comments.

@jfecher jfecher enabled auto-merge February 27, 2025 21:06
@github-actions GitHub Actions
Copy link
Contributor

FYI @noir-lang/developerrelations on Noir doc changes.

@jfecher jfecher added this pull request to the merge queue Feb 27, 2025
Merged via the queue into master with commit fdd2fe7 Feb 27, 2025
102 checks passed
@jfecher jfecher deleted the jf/as-trait branch February 27, 2025 21:31
@noirwhal noirwhal mentioned this pull request Feb 27, 2025
Open
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Mar 4, 2025
@AztecBot
[1 changes] chore!: remove deprecated hash functions from stdlib (noi…
a9253fa 
…r-lang/noir#7477)

fix(frontend)!: Restrict capturing mutable variable in lambdas (noir-lang/noir#7488)
feat: perform constant sha256 compressions at compile-time (noir-lang/noir#7566)
chore: bump external pinned commits (noir-lang/noir#7565)
chore(ssa): Turn the Brillig constraints check back on by default (noir-lang/noir#7404)
chore: bump external pinned commits (noir-lang/noir#7561)
chore: address some frontend tests TODOs (noir-lang/noir#7554)
fix: shift right overflow in ACIR with unknown var now returns zero (noir-lang/noir#7509)
chore(cli): Forward `nargo execute` to `noir_artifact_cli` (noir-lang/noir#7406)
feat: Support `<Type as Trait>::method` in expressions (noir-lang/noir#7551)
chore: remove FileDiagnostic (noir-lang/noir#7546)
chore: add some extra tests (noir-lang/noir#7544)
fix: fix a few cases where safety comment wasn't correctly identified (noir-lang/noir#7548)
chore!: remove U128 struct from stdlib (noir-lang/noir#7529)
feat: simplify simple conditionals for brillig (noir-lang/noir#7205)
chore: put RcTracker as part of the DIE context (noir-lang/noir#7309)
@AztecBot AztecBot mentioned this pull request Mar 4, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asterite asterite asterite approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support <Type as Trait> syntax
2 participants
@jfecher @asterite