-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(experiment): Compare bincode against other serialisation formats #7513
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Compilation Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20
.
Benchmark suite | Current: 67e98a9 | Previous: 6f78848 | Ratio |
---|---|---|---|
global_var_regression_entry_points |
2.03 s |
0.541 s |
3.75 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
bf8a365
to
d9df721
Compare
c14a35f
to
52da1a6
Compare
52da1a6
to
e21fccc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Execution Memory'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20
.
Benchmark suite | Current: 7eb28ac | Previous: 8516bbc | Ratio |
---|---|---|---|
rollup-block-root |
1810 MB |
1420 MB |
1.27 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
Description
Problem*
Related to #7511
Summary*
Comparing the impact on bytecode size of switching to a different serialisation format.
Additional Context
I'm interested in figuring out whether we can use one of the schema-less formats without paying too high a price for a backwards compatible format in terms of bloated bytecode size.
Compiling contracts
Run these commands to compile noir protocol circuits and contracts in aztec-packages after rebuilding
nargo
:Baseline
Recorded the bytecode size with
bincode
before switching to other implementations:./scripts/bytecode-sizes/print-bytecode-size.sh ../aztec-packages > ./scripts/bytecode-sizes/bincode.jsonl
Comparing bytecode
Run these commands to record a new measurement (e.g.
flexbuffers
here) and compare againstbincode
.Documentation*
Check one:
PR Checklist*
cargo fmt
on default settings.