Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add an extra constant folding pass #7033

Closed
wants to merge 1 commit into from

Conversation

TomAFrench
Copy link
Member

Description

Problem*

Resolves

Summary*

Testing stuff

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

Copy link
Contributor

Changes to number of Brillig opcodes executed

Generated at commit: 5e32a420a894f53a9d53805835a893e18bbb1620, compared to commit: db28cb9ffb710c286b54dbfcf57292ae3dffb03d

🧾 Summary (10% most significant diffs)

Program Brillig opcodes (+/-) %
nested_array_dynamic -14 ✅ -0.45%

Full diff report 👇
Program Brillig opcodes (+/-) %
nested_array_dynamic 3,128 (-14) -0.45%

Copy link
Contributor

Changes to Brillig bytecode sizes

Generated at commit: 5e32a420a894f53a9d53805835a893e18bbb1620, compared to commit: db28cb9ffb710c286b54dbfcf57292ae3dffb03d

🧾 Summary (10% most significant diffs)

Program Brillig opcodes (+/-) %
nested_array_dynamic -16 ✅ -0.75%
bigint -54 ✅ -2.57%

Full diff report 👇
Program Brillig opcodes (+/-) %
nested_array_dynamic 2,127 (-16) -0.75%
bigint 2,048 (-54) -2.57%

Copy link
Contributor

Changes to circuit sizes

Generated at commit: 5e32a420a894f53a9d53805835a893e18bbb1620, compared to commit: db28cb9ffb710c286b54dbfcf57292ae3dffb03d

🧾 Summary (10% most significant diffs)

Program ACIR opcodes (+/-) % Circuit size (+/-) %
nested_array_dynamic +237 ❌ +7.07% +562 ❌ +4.32%
nested_array_in_slice +28 ❌ +2.92% -28 ✅ -0.50%

Full diff report 👇
Program ACIR opcodes (+/-) % Circuit size (+/-) %
nested_array_dynamic 3,590 (+237) +7.07% 13,558 (+562) +4.32%
nested_array_in_slice 987 (+28) +2.92% 5,527 (-28) -0.50%

Copy link
Contributor

Compilation Memory Report

Program Peak Memory %
keccak256 78.96M 0%
workspace 123.83M 0%
regression_4709 424.09M 0%
ram_blowup_regression 1.86G 0%
rollup-base-public 4.85G 0%
rollup-base-private 1.26G 0%
private-kernel-tail 210.56M 1%
private-kernel-reset 669.11M 0%
private-kernel-inner 310.01M 5%

Copy link
Contributor

Execution Memory Report

Program Peak Memory
keccak256 74.67M
workspace 123.79M
regression_4709 316.00M
ram_blowup_regression 512.61M
rollup-base-public 479.47M
rollup-base-private 325.86M
private-kernel-tail 180.43M
private-kernel-reset 245.32M
private-kernel-inner 208.69M

Copy link
Contributor

Execution Report

Program Execution Time %
sha256_regression 0.051s 0%
regression_4709 0.001s 0%
ram_blowup_regression 0.631s 0%
rollup-root 0.100s -5%
rollup-block-merge 0.104s 0%
rollup-base-public 1.230s 0%
rollup-base-private 0.458s 0%
private-kernel-tail 0.019s 0%
private-kernel-reset 0.319s 0%
private-kernel-inner 0.070s -2%

Copy link
Contributor

Compilation Report

Program Compilation Time %
sha256_regression 1.364s 8%
regression_4709 0.829s 4%
ram_blowup_regression 21.360s 18%
rollup-root 3.342s -1%
rollup-block-merge 3.482s 2%
rollup-base-public 43.020s 3%
rollup-base-private 13.880s 6%
private-kernel-tail 0.994s 2%
private-kernel-reset 7.034s -4%
private-kernel-inner 2.124s 0%

@TomAFrench TomAFrench closed this Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant