Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove malformed functions from brillig reports #6898

Merged
merged 8 commits into from
Dec 20, 2024
Merged

chore: remove malformed functions from brillig reports #6898

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
43d625c
chore: remove malformed functions from brillig reports
TomAFrench Dec 20, 2024
d9d0142
.
TomAFrench Dec 20, 2024
3db44b4
.
TomAFrench Dec 20, 2024
91aea50
.
TomAFrench Dec 20, 2024
780b015
.
TomAFrench Dec 20, 2024
fedef53
.
TomAFrench Dec 20, 2024
c0f4910
.
TomAFrench Dec 20, 2024
0b7aefc
.
TomAFrench Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/reports.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ jobs:

- name: Compare gates reports
id: gates_diff
uses: noir-lang/noir-gates-diff@1931aaaa848a1a009363d6115293f7b7fc72bb87
uses: noir-lang/noir-gates-diff@84ada11295b9a1e1da7325af4e45e2db9f775175
with:
report: gates_report.json
summaryQuantile: 0.9 # only display the 10% most significant circuit size diffs in the summary (defaults to 20%)
Expand Down Expand Up @@ -121,7 +121,7 @@ jobs:

- name: Compare Brillig bytecode size reports
id: brillig_bytecode_diff
uses: noir-lang/noir-gates-diff@d88f7523b013b9edd3f31c5cfddaef87a3fe1b48
uses: noir-lang/noir-gates-diff@84ada11295b9a1e1da7325af4e45e2db9f775175
with:
report: gates_report_brillig.json
header: |
Expand Down Expand Up @@ -170,7 +170,7 @@ jobs:

- name: Compare Brillig execution reports
id: brillig_execution_diff
uses: noir-lang/noir-gates-diff@d88f7523b013b9edd3f31c5cfddaef87a3fe1b48
uses: noir-lang/noir-gates-diff@84ada11295b9a1e1da7325af4e45e2db9f775175
with:
report: gates_report_brillig_execution.json
header: |
Expand Down
2 changes: 1 addition & 1 deletion test_programs/gates_report.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ for pathname in $test_dirs; do
fi

GATES_INFO=$($BACKEND gates -b "$artifacts_path/$ARTIFACT_NAME/target/program.json")
MAIN_FUNCTION_INFO=$(echo $GATES_INFO | jq -r ".functions[0] | {package_name: "\"$ARTIFACT_NAME\"", functions: [{name: \"main\", acir_opcodes, opcodes: .acir_opcodes, circuit_size}]}")
MAIN_FUNCTION_INFO=$(echo $GATES_INFO | jq -r ".functions[0] | {package_name: "\"$ARTIFACT_NAME\"", functions: [{name: \"main\", acir_opcodes, opcodes: .acir_opcodes, circuit_size}], unconstrained_functions: []}")
echo -n $MAIN_FUNCTION_INFO >> gates_report.json

if (($ITER == $NUM_ARTIFACTS)); then
Expand Down
2 changes: 1 addition & 1 deletion test_programs/gates_report_brillig.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,6 @@ done

echo "]" >> Nargo.toml

nargo info --force-brillig --json > gates_report_brillig.json
nargo info --force-brillig --json | jq -r ".programs[].functions = []" > gates_report_brillig.json

rm Nargo.toml
4 changes: 2 additions & 2 deletions test_programs/gates_report_brillig_execution.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,6 @@ done

echo "]" >> Nargo.toml

nargo info --profile-execution --json > gates_report_brillig_execution.json
nargo info --profile-execution --json | jq -r ".programs[].functions = []" > gates_report_brillig_execution.json

rm Nargo.toml
rm Nargo.toml
Loading