Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix broken link in acvm-repo README #4412

Closed
wants to merge 4 commits into from
Closed

chore: fix broken link in acvm-repo README #4412

wants to merge 4 commits into from

Conversation

shak58
Copy link
Contributor

@shak58 shak58 commented Feb 22, 2024

Description

Problem*

This pull request resolves the issue with outdated and broken links in the acvm-repo README.md, which can lead to confusion when adding new crates to the workspace.

Summary*

Updated the README.md in acvm-repo to correct the relative paths to Cargo.toml, release-please-config.json, and .release-please-manifest.json. Also updated the incorrect reference from publish.yml to the correct publish-acvm.yml to reflect the current state of the repository workflows.

Additional Context

The previous link to publish.yml was broken, leading to a non-existent file. The updated links reference the documentation accurately.

Documentation*

  • No documentation needed.
  • Documentation included in this PR.
  • [Exceptional Case] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

Copy link
Contributor

github-actions bot commented Apr 3, 2024

Thank you for your contribution to the Noir language.

Please do not force push to this branch after the Noir team have started review of this PR. Doing so will only delay us merging your PR as we will need to start the review process from scratch.

Thanks for your understanding.

@shak58 shak58 closed this by deleting the head repository Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants