Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: lock version of grumpkin package #4269

Merged
merged 1 commit into from
Feb 6, 2024
Merged

chore: lock version of grumpkin package #4269

merged 1 commit into from
Feb 6, 2024

Conversation

TomAFrench
Copy link
Member

Description

Problem*

Resolves

Summary*

@kevaundray was very irresponsible and didn't specify a version for the noir-grumpkin dependency. The reviewer in the PR in which he made this mistake is entirely blameless.

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [Exceptional Case] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@TomAFrench TomAFrench requested a review from kevaundray February 6, 2024 00:35
@kevaundray
Copy link
Contributor

checks Reviewer ... :side-eye:

@kevaundray kevaundray added this pull request to the merge queue Feb 6, 2024
Merged via the queue into master with commit 27dc763 Feb 6, 2024
33 checks passed
@kevaundray kevaundray deleted the tf/grumpkin-version branch February 6, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevaundray kevaundray kevaundray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TomAFrench @kevaundray