Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(docs): stop committing codegenned docs #4186

Merged
merged 1 commit into from
Jan 29, 2024
Merged

chore(docs): stop committing codegenned docs #4186

merged 1 commit into from
Jan 29, 2024
+2 −870

Conversation

TomAFrench
Copy link
Member

@TomAFrench TomAFrench commented Jan 26, 2024 •
edited
Loading

Description

Problem*

Resolves

Summary*

We shouldn't be committing codegenned docs so this PR codegens directly into the processed-docs dir.

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [Exceptional Case] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jan 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

🚀 Deployed on https://65b3edba21b8ab3f4514ab21--noir-docs.netlify.app

@TomAFrench TomAFrench marked this pull request as ready for review January 26, 2024 17:53
@kevaundray kevaundray added this pull request to the merge queue Jan 29, 2024
Merged via the queue into master with commit 09bad2c Jan 29, 2024
37 checks passed
@kevaundray kevaundray deleted the tf/dont-commit-codegen branch January 29, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevaundray kevaundray kevaundray approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TomAFrench @kevaundray