Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: Remove unused Shl and Shr from Brillig IR #4129

Closed
wants to merge 1 commit into from

Conversation

kevaundray
Copy link
Contributor

Description

This was spotted by Facundo.

These are not being used in the IR and so have been removed, if you need this, one should instead use Multiplication or Signed/UnsignedDiv

Problem*

Resolves

Summary*

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [Exceptional Case] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@TomAFrench
Copy link
Member

We need to be do this over in aztec-packages as it's a serialisation change.

@kevaundray
Copy link
Contributor Author

We need to be do this over in aztec-packages as it's a serialisation change.

Ah forgot

@TomAFrench TomAFrench closed this Jan 23, 2024
@TomAFrench
Copy link
Member

Yeah, ideally our backend deserialiser should be robust enough to just ignore brillig entirely. #3907 would help on this.

@TomAFrench TomAFrench deleted the kw/shr-shl-remove branch November 20, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants