wip: Trying to make chumsky 1.0.0 work #4072
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfecher
reviewed
Jan 25, 2024
There was a problem hiding this comment.
Since this is not the first effort to migrate to 1.0, I think it's alright if we have to remove a few of our existing parser recovery tests to make this work. We'll re-evaluate / rework recovery at a later date anyway. IIRC last time we tried to migrate to 1.0 we got everything working sans 2 parser recovery tests.
Comment on lines
+118
to
+122
| // TODO why chumsky reports reversed ranges?? | ||
| if range.start > range.end { | ||
| range = Range { start: range.end, end: range.start }; | ||
| } else { | ||
| } |
There was a problem hiding this comment.
This has been a problem in the past when using certain error recovery strategies I think. Hopefully it hasn't gotten more common with 1.0 😅
|
Because release candidates for
|
|
Closing as this branch seems abandoned |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves
Summary*
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.